Skip to content

Binpatch: "bin not found / already patched" if the pattern is in SSDT, but it's being patched even so #379

@kushwavez

Description

@kushwavez

If I rename something that is not in DSDT, but in SSDT, log says "bin not found / already patched" even if it's being patched.

For example _UPC to XUPC (_UPC is ONLY in SSDT's, not in DSDT):
I looked up my SSDT-4.aml with HexFiend to find the pattern, found:

  • _UPC? (5F555043 08A4)
  • 6_UPC (365F5550 43)
  • %_UPC (255F5550 43)

If I look at the log, it says:

10:786  0:000   - [_UPC? to XUPC]: pattern 5F555043, bin not found / already patched!
10:786  0:000   - [6_UPC to XUPC]: pattern 365F5550, bin not found / already patched!
10:786  0:000   - [%_UPC to XUPC]: pattern 255F5550, bin not found / already patched!

In this case this msg is at the first attempt for patch, so it isn't "already patched"

But they're patched, looking at my SSDT-4, so that's why I say it's cosmetic issue:
Képernyőfotó 2021-03-11 - 10 55 10

If it's in my DSDT, for example _GPE.NTFY (CGNTFY: 43474E54 4659) to XTFY it says:
10:787 0:000 - [GPE_NTFY to XTFY]: pattern 43474E54, patched at: [ (16B81) ]
So, if it's in DSDT it's reporting correctly.

[...]
3:604  0:000   - [SSDT-3: RP09._PS0 to XPS0]: pattern 3C5F5053, bin not found / already patched!
3:604  0:000   - [SSDT-3: RP09._PS3 to XPS3]: pattern 3C5F5053, bin not found / already patched!
3:604  0:000   - [DSDT: RP09._INI to XINI]: pattern 5F414452, patched at: [ (8E2D) ]
3:605  0:000   - [DSDT: CGNTFY to XTFY]: pattern 43474E54, patched at: [ (16B81) ]
3:605  0:000   - [SSDT-4: _UPC? to XUPC]: pattern 5F555043, bin not found / already patched!
3:605  0:000   - [SSDT-4: 6_UPC to XUPC]: pattern 365F5550, bin not found / already patched!
3:605  0:000   - [SSDT-4: %_UPC to XUPC]: pattern 255F5550, bin not found / already patched!
3:605  0:000   - [DSDT: XHC: _PS0 to XPS0]: pattern 1442105F, patched at: [ (5FD0) ]
3:605  0:000   - [DSDT: XHC: _PS3 to XPS3]: pattern 14463F5F, patched at: [ (60D3) ]
[...]

Attaching log:
2021-3-11_11-23-21_CLOVERX64.efi.log

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions