New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load-to-ccldoc-form: source note map seems to be ignored #4

Closed
phoe opened this Issue Oct 3, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@phoe
Contributor

phoe commented Oct 3, 2017

https://github.com/Clozure/ccldoc/blob/master/source/toplevel.lisp#L40
This is where *nx-source-note-map* is declared, it is a dynamic binding.

https://github.com/Clozure/ccldoc/blob/master/source/toplevel.lisp#L46
This is where the map is updated.

Is it just me, or is the hashtable not accessed anywhere else in CCLDOC and therefore wasted?

@phoe

This comment has been minimized.

Contributor

phoe commented Oct 3, 2017

@phoe phoe closed this Oct 3, 2017

@xrme

This comment has been minimized.

Member

xrme commented Oct 3, 2017

GitHub is the best place for issues now.

*nx-source-note-map* is used to make M-. work on the forms that precede the document contents. It's a nice-to-have thing, but it's not actually needed to process a ccldoc document.

@xrme xrme reopened this Oct 3, 2017

@xrme

This comment has been minimized.

Member

xrme commented Oct 12, 2017

@phoe I think you have this figured out now.

@xrme xrme closed this Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment