[FLOC-4438] Upgrade to Twisted 16.3.0 #2826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s some other new library versions.
…isted-16.3.0-FLOC-4438
wallrj
changed the title
|
Looks good, @wallrj . Do you plan to address pylint issues in this PR or a follow up? Thanks! |
… have found lots of new examples in the Flocker code which I haven't got time to fix right now.
I've disabled that check for now. Looks like we enabled it in #2556 (for good reasons) But I'm not going to try and fix all these new unused-variable warnings here. I've created a followup issue. |
|
Twisted has moved on to 16.4 and this branch is now out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://clusterhq.atlassian.net/browse/FLOC-4438
Includes a bunch of other library updates.
All minor or micro version updates so hopefully won't cause problems.
See: http://twistedmatrix.com/pipermail/twisted-python/2016-July/030535.html