Skip to content

Dev: ui_node: Improve command 'clearstate <node>' #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

Dev: ui_node: Improve command 'clearstate <node>' #1534

merged 1 commit into from
Sep 6, 2024

Conversation

@liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Aug 30, 2024 •
edited
Loading

Log an error and return False if the node is not found in CIB, avoid IndexError for subsequent code

@liangxin1300
Dev: ui_node: Improve command 'clearstate <node>'
ed8a42c 
Log an error and return False if the node is not found in CIB.
@liangxin1300 liangxin1300 mentioned this pull request Aug 30, 2024
Merged
@codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.70%. Comparing base (9e72303) to head (ed8a42c).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/ui_node.py 0.00% 3 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 54.52% <0.00%> (-0.01%) ⬇️
unit 52.40% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/ui_node.py 43.51% <0.00%> (-0.34%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review September 6, 2024 03:03
nicholasyang2022
nicholasyang2022 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

liangxin1300 added a commit that referenced this pull request Sep 6, 2024
@liangxin1300
[crmsh-4.6] Dev: ui_node: Improve command 'clearstate <node>' (#1535)
b10a818 
backport #1534
@liangxin1300 liangxin1300 merged commit 567166c into ClusterLabs:master Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicholasyang2022 nicholasyang2022 nicholasyang2022 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liangxin1300 @nicholasyang2022