Skip to content

Conversation

@liangxin1300
Copy link
Collaborator

When cluster is not running, load CIB_file environment variable before some readonly commands to avoid the error message. (issue #1499 )

Current affected commands:

  • crm configure show
  • crm configure get_property
  • crm configure verify
  • crm node show
  • crm node server

@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (6239959) to head (687af2f).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/ui_node.py 0.00% 2 Missing ⚠️
crmsh/ui_configure.py 66.66% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 54.57% <75.00%> (+<0.01%) ⬆️
unit 52.37% <8.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/utils.py 68.31% <100.00%> (+0.11%) ⬆️
crmsh/ui_configure.py 45.09% <66.66%> (+0.07%) ⬆️
crmsh/ui_node.py 43.62% <0.00%> (-0.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 force-pushed the 20240903_issue_1499_read_only branch from 33a5a64 to b0a746f Compare September 3, 2024 03:19
@liangxin1300 liangxin1300 marked this pull request as ready for review September 3, 2024 03:49
When cluster is not running, load CIB_file environment variable
before some readonly commands to avoid the error message.

Current affected commands:
- crm configure show
- crm configure get_property
- crm configure verify
- crm node show
- crm node server
@liangxin1300 liangxin1300 force-pushed the 20240903_issue_1499_read_only branch from b0a746f to 687af2f Compare September 3, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants