Skip to content

Conversation

@liangxin1300
Copy link
Collaborator

Give user a hint that the cluster name should not be renamed when using qdevice, should remove qdevice first.

And also automatically restart cluster when there is no any resource running, when renaming the cluster name.

Fix issue #1465

Give user a hint that the cluster name should not be renamed when using
qdevice, should remove qdevice first.

And also automatically restart cluster when there is no any resource
running, when renaming the cluster name.

Fix issue ClusterLabs#1465
@codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.75%. Comparing base (113b211) to head (ee78d7f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/ui_cluster.py 9.09% 10 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 54.57% <42.10%> (-0.02%) ⬇️
unit 52.59% <42.10%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 88.62% <100.00%> (+0.01%) ⬆️
crmsh/qdevice.py 98.73% <100.00%> (-0.01%) ⬇️
crmsh/sbd.py 91.96% <100.00%> (-0.05%) ⬇️
crmsh/ui_cluster.py 75.09% <9.09%> (-1.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review October 8, 2024 12:09
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liangxin1300 liangxin1300 merged commit 6e8ba2a into ClusterLabs:master Oct 9, 2024
31 of 32 checks passed
liangxin1300 added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants