Collect ~/.config/crm/crm.conf in crm report result #1622
Merged
+45
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
liangxin1300
force-pushed
the
20241127_collect_crm_conf
branch
3 times, most recently
from
a61eb16 to
c229fcc
Compare
crmsh/report/collect.py
Outdated
| for log in log_list: | ||
| log_list = [ | ||
| os.path.expanduser(log) | ||
| if log.startswith("~") else log |
There was a problem hiding this comment.
No need to test startwith("~"). os.path.expanduser() handles paths without leading ~ correctly.
Create {basename}.d directory in report result and put those files in
it. Then files like `/etc/crm/crm.conf` and `/root/.config/crm/crm.conf`
will under `crm.conf.d` directory.
which was used by ocfs2, but ocfs2 related code has been removed.
liangxin1300
force-pushed
the
20241127_collect_crm_conf
branch
from
c229fcc to
f523ac9
Compare
nicholasyang2022
approved these changes
Dec 9, 2024
liangxin1300
added a commit
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
The file
~/.config/crm/crm.confis now collected in crm report resultTo manage files that have the same basename (e.g.,
crm.conf), the PR implements a new directory. When multiple files share the same basename, a directory named{basename}.dis created in the report result. All files with the same basename are then placed inside this directory. For instance, the files/etc/crm/crm.confand/root/.config/crm/crm.confwill be placed inside a directory namedcrm.conf.d