-
Notifications
You must be signed in to change notification settings - Fork 95
Fix: ra: Prevent to add unknown operation (bsc#1236442) #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ra: Prevent to add unknown operation (bsc#1236442) #1679
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
5d54ee1 to
b7c15db
Compare
033a45c to
eb8e9fc
Compare
3128845 to
a533416
Compare
a533416 to
356f0a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It is invalid to use bitwise-or operation with a series defined as 0, 1, 2, 3, ....
- Please use enum instead instead of standalone integers.
6952df8 to
7dec671
Compare
- When adding unknown operation, sanity check should give an error instead of a warning - Create enum class utils.VerifyResult to represent the return value of verify functions, include SUCCESS, WARNING, NON_FATAL_ERROR and FATAL_ERROR - sanity check will return utils.VerifyResult.FATAL_ERROR to indicate this is a fatal error, so that the commit process will be aborted
7dec671 to
0393954
Compare
error, so that the commit process will be aborted