Fix: ui_cluster: Return when cluster service on all nodes are already startd (bsc#1241358) #1746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangxin1300
force-pushed
the
20250417_restart_return_value
branch
from
c23c4fa to
cede171
Compare
zzhou1
reviewed
Apr 18, 2025
crmsh/ui_cluster.py
Outdated
| logger.error('%s', msg) | ||
| logger.info("Please try 'crm cluster start' on each node") | ||
| return False | ||
| return |
There was a problem hiding this comment.
Why is NoSSHEror also changed?
There was a problem hiding this comment.
It makes sense to me to stay as "1"
adm@tw-1:~> sudo crm cluster start --all; echo $?
INFO: The cluster stack already started on tw-1
ERROR: cluster.start: Failed to run command systemctl is-active 'pacemaker.service' on adm@tw-2: adm@tw-2: Permission denied (publickey,password,keyboard-interactive). Environment variable SSH_AUTH_SOCK does not exist. Please check whether ssh-agent is available and consider using "sudo --preserve-env=SSH_AUTH_SOCK".
1
adm@tw-1:~> sudo crm cluster stop --all; echo $?
ERROR: cluster.stop: Failed to run command systemctl is-active 'corosync.service' on adm@tw-2: adm@tw-2: Permission denied (publickey,password,keyboard-interactive). Environment variable SSH_AUTH_SOCK does not exist. Please check whether ssh-agent is available and consider using "sudo --preserve-env=SSH_AUTH_SOCK".
1
There was a problem hiding this comment.
And, all the following should return "0"
adm@tw-1:~> sudo crm cluster stop; echo $?
INFO: The cluster stack stopped on tw-1
0
adm@tw-1:~> sudo crm cluster start; echo $?
INFO: Starting pacemaker.service on tw-1
INFO: The cluster stack started on tw-1
0
adm@tw-1:~> sudo crm cluster start; echo $?
INFO: The cluster stack already started on tw-1
0 # <-- only fix here
709bee9 to
6c67963
Compare
… startd (bsc#1241358)
liangxin1300
force-pushed
the
20250417_restart_return_value
branch
from
6c67963 to
4c358ca
Compare
…Error To keep consistency with the return value of `crm cluster start` when raise NoSSHError
liangxin1300
force-pushed
the
20250417_restart_return_value
branch
from
4c358ca to
f76f6b7
Compare
nicholasyang2022
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cluster is already started, the return value of
crm cluster startis 1, which was expected as 0This regression was introduced from #1692