Dev: utils: Enhance maintenance mode management with detection and type hints #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe hints - Add detection to check if the cluster is already in maintenance mode. If yes, yield `True` and exit early to avoid resetting the maintenance mode unnecessarily. - Introduce docstring to describe the behavior of the `leverage_maintenance_mode` function. - Add proper type hints to the function, specifying it returns a `Generator[bool, None, None]`.
zzhou1
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add detection to check if the cluster is already in maintenance mode. If yes, yield
Trueand exit early to avoid resetting the maintenance mode unnecessarily.Introduce docstring to describe the behavior of the
leverage_maintenance_modefunction.Add proper type hints to the function, specifying it returns a
Generator[bool, None, None].Fix issue #1759