Dev: cibconfig: Use VerifyResult to define the return value of sanity check related functions

[liangxin1300]

#1679 only updated some sanity check functions and failed to change all related return values to use VerifyResult.

This PR ensures that all related functions now consistently use VerifyResult as the return value.

[Copilot]

Pull Request Overview

This PR updates several sanity check functions and their related tests to consistently return values of type VerifyResult instead of plain integers. Key changes include updating test assertions in the unit tests, modifying the functions in crmsh/ra.py to return VerifyResult (with type annotations) instead of numeric codes, and updating various return statements in crmsh/cibconfig.py accordingly.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
test/unittests/test_bugs.py	Updated sanity check assertions to compare against VerifyResult values and added a utils import.
crmsh/ra.py	Replaced numeric return codes with VerifyResult constants and added proper type annotations.
crmsh/cibconfig.py	Modified functions to consistently return VerifyResult and updated bitwise flag usage.

Comments suppressed due to low confidence (1)

crmsh/ra.py:1216

• Ensure that the VerifyResult type supports bitwise operations and guarantees predictable results when combined. If not, consider implementing a dedicated method for combining or evaluating verify statuses.

rc = VerifyResult.WARNING

[Copilot]

[nitpick] Consider replacing the membership check ('in') with an explicit bitwise or equality comparison to clearly express the expected VerifyResult flag. This will improve clarity for maintainers unfamiliar with the VerifyResult type’s internals.

Suggested change

	assert c and bool(rc) is True and utils.VerifyResult.WARNING in rc
	assert c and bool(rc) is True and (rc & utils.VerifyResult.WARNING) == utils.VerifyResult.WARNING

[Copilot]

[nitpick] Add inline documentation or comments to explain the use of VerifyResult as return values in these functions and how to interpret combined flags. This will aid future maintainers in understanding the intended logic.

Suggested change

	rc = VerifyResult.SUCCESS
	for param, resources in list(clash_dict.items()):
	# at least one new object must be involved
	# Initialize the return code as SUCCESS. This will be updated to WARNING
	# if any uniqueness violations are detected involving new objects.
	rc = VerifyResult.SUCCESS
	for param, resources in list(clash_dict.items()):
	# At least one new object must be involved in the clash for a WARNING.