Skip to content

Dev: sbd: Add pcmk_delay_max back to calculate SBD_DELAY_START #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

Dev: sbd: Add pcmk_delay_max back to calculate SBD_DELAY_START #1873

merged 3 commits into from
Jul 23, 2025

Conversation

@liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Jul 22, 2025 •
edited
Loading

In PR #1740, the parameter pcmk_delay_max was removed. However, the formula for SBD_DELAY_START still needs to account for the pcmk_delay_max factor [1]. This PR restores the use of pcmk_delay_max in the calculation.

[1] #1740 (comment)

@codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.62%. Comparing base (33900d1) to head (cd1d7ec).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
crmsh/utils.py 25.00% 3 Missing ⚠️
crmsh/sbd.py 50.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 55.06% <16.66%> (-0.01%) ⬇️
unit 52.99% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/sbd.py 87.09% <50.00%> (-0.18%) ⬇️
crmsh/utils.py 67.97% <25.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300 liangxin1300 mentioned this pull request Jul 23, 2025
Merged
@liangxin1300 liangxin1300 marked this pull request as ready for review July 23, 2025 09:56
gao-yan
gao-yan approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@gao-yan gao-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@liangxin1300 liangxin1300 merged commit 07081e3 into ClusterLabs:master Jul 23, 2025
35 of 36 checks passed
liangxin1300 added a commit that referenced this pull request Jul 23, 2025
@liangxin1300
[crmsh-4.6] Dev: sbd: Add pcmk_delay_max back to calculate SBD_DELAY_…
bf34c59 
…START (#1875)

Changes:
- Dev: behave: Change the expected value of SBD_WATCHDOG_TIMEOUT and
stonith-timeout
These values in testcases in file bootstrap_sbd_delay.feature should be
updated first before backport

- backport #1873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gao-yan gao-yan gao-yan approved these changes

@nicholasyang2022 nicholasyang2022 Awaiting requested review from nicholasyang2022

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liangxin1300 @gao-yan