Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fence_rhevm: Changed Encoding to UTF-8 #255

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Numblesix
Copy link
Contributor

Starting from RHV/Ovirt 4.2 we saw issues with the agent(unable to fence) after switching to UTF-8 all worked again.

Starting from RHV/Ovirt 4.2 we saw issues with the agent(unable to fence) after switching to UTF-8 all worked again.
@knet-ci-bot
Copy link

Can one of the admins verify this patch?

@oalbrigt
Copy link
Collaborator

oalbrigt commented Jan 29, 2019

Are you using another encoding on your system? I just want to know what causes the issue in case we might need to do something more advanced to avoid it for all in the future.

@oalbrigt oalbrigt changed the title Changed Encoding to UTF-8 fence_rhevm: Changed Encoding to UTF-8 Jan 29, 2019
@Numblesix
Copy link
Contributor Author

I tested it on 4 fresh RHEL7.6 installation all on de_DE.UTF-8, maybe as a side note we only saw this when the pcs cluster tried to fence(stonith admin) the other node in the cluster (2 node Cluster)

@oalbrigt
Copy link
Collaborator

Thanks. That confirms my worries. I think we'll have to default to UTF-8, and have an option to change it, that I'll add.

@oalbrigt oalbrigt merged commit 68dee49 into ClusterLabs:master Jan 30, 2019
@Numblesix
Copy link
Contributor Author

Why would somebody need to change it from UTF-8 ? Just to understand it :)

@oalbrigt
Copy link
Collaborator

Maybe if Japanese or Chinese use other charsets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants