Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix: It corrected so that the reading pipe which is not closed might be ... #255

Merged
merged 1 commit into from

2 participants

@yuusuke

...closed.

When I repeated the start stop of the resource, the number of opening pipes of crmd increases.
It seems that this occurs when crmd tends to acquire metadata of a resource.
Since I seemed not to close the pipe of this reading, after I finished using, I closed.
Remains of a pipe are prevented by this correction.

@beekhof
Owner

Looks reasonable

@beekhof beekhof merged commit 6baccba into ClusterLabs:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 12, 2013
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 0 deletions.
  1. +3 −0  lib/services/services_linux.c
View
3  lib/services/services_linux.c
@@ -452,6 +452,9 @@ services_os_action_execute(svc_action_t * op, gboolean synchronous)
read_output(op->opaque->stdout_fd, op);
read_output(op->opaque->stderr_fd, op);
+ close(op->opaque->stdout_fd);
+ close(op->opaque->stderr_fd);
+
} else {
crm_trace("Async waiting for %d - %s", op->pid, op->opaque->exec);
mainloop_add_child(op->pid, op->timeout, op->id, op, operation_finished);
Something went wrong with that request. Please try again.