Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback name for ocf_attribute_target #1066

Merged
merged 1 commit into from Dec 7, 2017

Conversation

dciabrin
Copy link
Contributor

@dciabrin dciabrin commented Dec 5, 2017

For bundles, various resource agents now use ocf_attribute_target to
get the name of the pacemaker node to store attributes on.

If a recent version of the resource agent is being run on a pacemaker
version which does not support bundles, ocf_attribute_target will
return an empty string as hostname.

Provide a fallback path so the resource agent gets a valid name when
the resource is not containerized.

For bundles, various resource agents now use ocf_attribute_target to
get the name of the pacemaker node to store attributes on.

If a recent version of the resource agent is being run on a pacemaker
version which does not support bundles, ocf_attribute_target will
return an empty string as hostname.

Provide a fallback path so the resource agent gets a valid name when
the resource is not containerized.
@dciabrin
Copy link
Contributor Author

dciabrin commented Dec 5, 2017

Please do not merge it right away, I'd like to discuss that so we all agree on when that can happen and whether that's the proper fix or not.

@dciabrin
Copy link
Contributor Author

dciabrin commented Dec 7, 2017

OK, I've tested this PR by creating a galera resource with the latest resource-agents, on a cluster managed by an old pacemaker from RHEL 7.2.
Without this fix, the resource won't come up due to the agent not setting the attributes properly in the CIB.
With this fix, the resource goes to master state as expected.

@oalbrigt oalbrigt merged commit 05567e3 into ClusterLabs:master Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants