This agnet supports running Bird route daemon with master-slave
architecture for managing IP failover using static routes
Plugin for running Bird route damon
No need for this; we have ocf_is_ms.
Cut and paste error? Please update with a correct copyright notice.
Can you explain under what circumstances this should be run as a master/slave set, and under what it shouldn't? Most RAs either only make sense as primitives, or only as M/S sets.
Err, no. start shouldn't come back with $OCF_RUNNING_MASTER, only promote should.
Nope. The config file may still be just fine on a different node; this has to return $OCF_ERR_INSTALLED.
Thanks for the submission. I wonder if you have taken a look at http://www.linux-ha.org/doc/dev-guides/ra-dev-guide.html -- if you haven't, please do so now and fix up the RA accordingly.
Note that we are just nearing a release, so this new addition may not get much attention until the release is cut. In that case, we will return to the review after that.
Looks like you're missing the point of validate_all. Also, the meaning of the various OCF exit codes, in particular OCF_ERR_CONFIGURED.
Please read the development guide, as already suggested by fghaas. If there's anything unclear, ask on the linux-ha-dev mailing list.
Fixes as suggested by fghaas
Thanks for your comments and feedback.
As suggested, I fixed most of the commented code. Also, there is more info on meta action when, and how to use this agent in master-slave mode.
To the comment on start action and RUNNING_MASTER state - I'm retturning OCF_SUCCESS, not RUNNING_MASTER, so it is as you worte.
I'm using dev-guide while developing this resource agents (this is my first one), but nothing in clear on the first-shot.
Thank you for your attention time and feedback.
OCF_ERR_CONFIGURED is used when a particular RA is not well configured (usually missing parameters). This should probably return "err_generic".
Again, OCF_ERR_CONFIGURED should be returned only in validate_all. It can be caused only by the static RA configuration, as defined by the user, not by the current system state.
Probably won't make any difference, but it would be correct to do "return $ret" here.
This comment is misleading.
This is the stop action. Update comment.
This comment seems to be misplaced.
Is this parameter supposed to be unique?
Hmm, why is this OCF_ERR_CONFIGURED? This check is superfluous. Isn't the RA supposed to also start the daemon?
This parameter is not required. It is only used iff the RA runs as ms.
This check doesn't belong here.
The next resource-agents release happens next week. Please fix the issues if you want it merged beforehand. Thanks!
@rafaltrojniak no news here for a long time. Do you want to bring this to a state in which it can be merged? Thanks!
Hey, thanks for the bumping this task up.
Currently it is not my priority to make this working, but I implement most of Your comments in some time.
This can take one or two months, after my current, urgent and high priority project will be completed.
typo fix in Bird
Merge pull request #1 from jkramarz/patch-1
@rafaltrojniak still no news. Note that there'll be a release mid January.
I'm sorry, but I am not able to test it with my current resources, or maintain this. It looks like I have to drop this project.