podman-etcd: compute dynamic revision bump from maxRaftIndex #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded 1 billion revision bump with dynamic calculation based on 20% of the last known maxRaftIndex from revision.json. This aligns with the logic used by cluster-etcd-operator's quorum-restore-pod utility and ensures the bump amount is proportional to the cluster's actual revision state. The implementation: - Adds compute_bump_revision() function with safe fallback to 1bn default - Extracts magic values to named constants (ETCD_REVISION_BUMP_PERCENTAGE, ETCD_BUMP_REV_DEFAULT, ETCD_REVISION_JSON) - Validates computed values (non-zero, not exceeding default) - Logs computation results for debugging Reference: https://github.com/openshift/cluster-etcd-operator/blob/215998939f5223da9166 22c71fd07d17656faf6b/bindata/etcd/quorum-restore-pod.yaml#L26-L34
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2087/1/input |
oalbrigt
approved these changes
Oct 22, 2025
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2087/2/input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded 1 billion revision bump with dynamic calculation based on 20% of the last known maxRaftIndex from revision.json.
This aligns with the logic used by cluster-etcd-operator's quorum-restore-pod utility and ensures the bump amount is proportional to the cluster's actual revision state.
The implementation:
Reference:
https://github.com/openshift/cluster-etcd-operator/blob/215998939f5223da916622c71fd07d17656faf6b/bindata/etcd/quorum-restore-pod.yaml#L26-L34