Skip to content

3 things #23

Merged
merged 4 commits into from Dec 7, 2012

1 participant

@ghost
ghost commented Dec 7, 2012
  • making sure the default *use-context-classloader* being false is explicit

  • and don't add cljminecraft .jar to classpath because its parent already has it

  • overriding getResource() will warn us in the future if anything we do (ie. using class-loader-of) will detect loading of a shadowed resource(it exists in more than 1 jar from the classpath which typically is cljminecraft and memorystone and any other cljminecraft dependent clojure plugin), at least if we're using this.getResource("filename") (bukkit does) and not some other way.

@CmdrDats CmdrDats commented on the diff Dec 7, 2012
javasrc/cljminecraft/ClojurePlugin.java
@@ -8,7 +10,7 @@
*/
public class ClojurePlugin extends BasePlugin {
- private final static String selfPluginName=ClojurePlugin.class.getPackage().getName();//"cljminecraft";
@CmdrDats
Owner
CmdrDats added a note Dec 7, 2012

This field got moved to the parent class, shouldn't the selfCoreScript also move there? I don't like referring directly to fields in parent classes and since BasePlugin is also very Clojure aware, might as well handle the selfCoreScript from there too?

Just a thought

@ghost
ghost added a note Dec 7, 2012

3 things · Pull Request #23 · CmdrDats/clj-minecraft · GitHub
Vanessa Bruno http://vanessabruno.navtone.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@CmdrDats CmdrDats merged commit f9b16db into CmdrDats:master Dec 7, 2012
@CmdrDats
Owner
CmdrDats commented Dec 7, 2012

Great work, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.