Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Spec for card image download priority order #2479
Currently we have a loosely-defined image url download priority order with fallback.
The goal of this ticket is to come up with a flexible, understandable design that helps users get the images they want.
At a high level, we currently have:
I propose instead:
When a card image is requested:
This was referenced
Mar 14, 2017
FYI I'm going to take a look at this (so multiple people aren't working on the same thing). The first thing I'd like to do is just take the 2 existing URLs and fall back as expected: On 404 for the first one, (instead of muid of card), going by set in priority order.
The list of multiple URLs by priority could come in a later PR. No idea how long I expect it to take.
I have something tentatively working, here's a log in action.
This is using:
For the set that doesn't match, the download is attempted, but then it moves the secondary URL, then to the next set. Code needs to be cleaned up and tested more thoroughly, but it's looking good so far.