Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Card image loading: Fallback on 404 #3367
Short roundup of the initial problem
What will change with this Pull Request?
If transformUrl is called with a template, and the card/set is missing something required by that template, it will now return an empty string, instead of the template with an empty string substituted in.
This removes some redundant code that is better replaced with a call to nextUrl, in case the code needed to populate the nextUrl changes significantly.
Thanks for the feature! :)
@andrewzwicky please remove the
Otherwise it ends up in our commit list and is a bit confusing:
I changed it now, but that won't change the history.