Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix volume slider on qt6 #4642

Merged
merged 1 commit into from
Sep 1, 2022
Merged

fix volume slider on qt6 #4642

merged 1 commit into from
Sep 1, 2022

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Jun 15, 2022

sound never worked on qt6, the volume setting goes from 0 to 1 instead of 0 to 100

@ebbit1q
Copy link
Member Author

ebbit1q commented Jun 15, 2022

while this does fix the volume slider there seems to be a different issue on my system, the qt6 version only plays sound after I compile it until I run any other version of cockatrice on the same system, and there is always some audio clipping not present on the qt5 build

@tooomm
Copy link
Member

tooomm commented Jun 16, 2022

Sound seems to work with the Win10 64bit file from this PR.

@ebbit1q
Copy link
Member Author

ebbit1q commented Jun 16, 2022

does this pr fix the ability to set the volume compared to the latest win10 64 beta for you?

@tooomm
Copy link
Member

tooomm commented Jun 16, 2022

Yes. It fixes it for me. 👍

@ebbit1q ebbit1q changed the title fix sound on qt6 fix volume slider on qt6 Jun 16, 2022
Copy link
Member

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested again and confirm this works for Windows with Qt6. 👍

On beta.10 adjusting the volume has no effect, e.g. volume slider at 2 is as loud as at 100.
Only enabling/disabling works via the check box. Or putting the slider to 0 (disabled) or non 0 (enabled).

Client Version: 2.8.1-beta.10 (2022-09-01)
Client Operating System: Windows 10 Version 2009
Build Architecture: 64-bit
Qt Version: 6.3.1
System Locale: en_GB
Install Mode: Standard

With the fix from this PR in 2.8.1-custom(0221b0e) / Win10+-64bit with Qt6, the volume slider has expected functionality.


there seems to be a different issue on my system, the qt6 version only plays sound after I compile it until I run any other version of cockatrice on the same system, and there is always some audio clipping not present on the qt5 build

I don't think I've those issues on my machine as far as I can tell. 🤔

@ebbit1q ebbit1q merged commit 235adbb into Cockatrice:master Sep 1, 2022
@ebbit1q ebbit1q deleted the qt6sound branch September 1, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants