Custom logsDirectory #1

Closed
wants to merge 5 commits into
from

Projects

None yet

2 participants

@coryroloff

Hey there,

Love the framework you've created, but I needed the ability to specify a custom logs directory for the app I'm building. There aren't that many changes, so I hope it's not an issue. I followed your conventions as best I could. Just thought I'd share it with you.

Basically, I just added a setter for the logsDirectory property and added a line to the logsDirectory method to use your custom path if you specified one. Otherwise it'll use the default application support directory based on which device you're on.

If you see any issues with the code let me know!

Thanks!

@robbiehanson
Collaborator

Merged your changes. However I made the logsDirectory settable only in the init method, which removes complications if someone attempts to change the logsDirectory in the middle of operation. I also merged in your DDLogFileInfo description method - nice touch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment