Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullability violations #1287

Merged
merged 3 commits into from Feb 16, 2022

Conversation

jcbertin
Copy link
Contributor

@jcbertin jcbertin commented Feb 11, 2022

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

Pull Request Description

After enabling nullability violations checks, I found an issue where _currentLogFileInfo could be used before being initialized. This PR fixes that.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #1287 (b248832) into master (cff9d3e) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
- Coverage   48.26%   48.26%   -0.01%     
==========================================
  Files          32       32              
  Lines        5200     5203       +3     
  Branches      488      489       +1     
==========================================
+ Hits         2510     2511       +1     
- Misses       2501     2504       +3     
+ Partials      189      188       -1     
Impacted Files Coverage Δ
Sources/CocoaLumberjack/DDFileLogger.m 52.56% <25.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff9d3e...b248832. Read the comment docs.

Copy link
Member

@ffried ffried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have one small question (see inline).

Sources/CocoaLumberjack/DDFileLogger.m Show resolved Hide resolved
@ffried ffried merged commit 7592cbb into CocoaLumberjack:master Feb 16, 2022
@jcbertin jcbertin deleted the fix-nullability-violations branch February 16, 2022 16:53
fengjixuchui added a commit to fengjixuchui/CocoaLumberjack that referenced this pull request Feb 16, 2022
Merge pull request CocoaLumberjack#1287 from jcbertin/fix-nullability…
@jcbertin jcbertin mentioned this pull request Feb 16, 2022
8 tasks
ffried added a commit that referenced this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants