Added new flag DDVERBOSE to DDLog so you can have another state. #145

Merged
merged 4 commits into from Nov 8, 2013

3 participants

@nicoyuste

Added new flag DDVERBOSE to DDLog so you can have another state.

@rivera-ernesto
CocoaLumberjack member

I think an extra level is good, but the name is a little bit weird.

Most systems would have:

  • Error
  • Warning
  • Info
  • Debug (new one?)
  • Verbose
@bpoplauschi
CocoaLumberjack member

I agree with @rivera-ernesto, the name is a little weird. I'm not sure why we would need an extra level, but if this helps people, I'm ok with that. For me, the 4 Error Warning Info Verbose represent the important categories of logs you might have and there is always the option to redefine them (https://github.com/robbiehanson/CocoaLumberjack/wiki/CustomLogLevels)

@rivera-ernesto
CocoaLumberjack member

So @nicoyuste what do you think about renaming it?

@nicoyuste
@bpoplauschi
CocoaLumberjack member

@nicoyuste Yeap, I would go with:

  • Error
  • Warning
  • Info
  • Debug
  • Verbose

Can you update the pull request with a new commit?

Seems like this is the commonly used approach (for example log4j: http://en.wikipedia.org/wiki/Log4j).

@nicoyuste
@bpoplauschi
CocoaLumberjack member

@nicoyuste any updates?

@nicoyuste

Ok! Done!

Now it works this way:
1 - Error
2 - Warning
3 - Info
4 - Debug
5 -Verbose

@rivera-ernesto rivera-ernesto merged commit 8e68787 into CocoaLumberjack:master Nov 8, 2013
@rivera-ernesto
CocoaLumberjack member

Nice!

@rivera-ernesto rivera-ernesto added a commit to rivera-ernesto/CocoaLumberjack that referenced this pull request Nov 13, 2013
@rivera-ernesto rivera-ernesto Add new DEBUG log level support to included loggers
Complements #145.
2869086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment