Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Travis support #169

Merged
merged 3 commits into from

2 participants

@rivera-ernesto
Collaborator

Build every demo project using Travis CI to check for the status of the all the branches, and more important check the status of pull request code (such as below).

Waiting for #150 to make it cleaner and enable it for all pull requests and not only mine's.

@bpoplauschi
Collaborator

This is great stuff. Quick question: should Travis run all those projects before validating pull requests? Wouldn't Xcode/LumberjackFramework/Desktop and Xcode/LumberjackFramework/Mobile be enough?

Collaborator

It is running all of them.

Collaborator

I know it's running them because that is what is written in the travis config file. My question was: do we need so many or can we use just 2 of them?

@bpoplauschi
Collaborator

@rivera-ernesto the pull request looks good, but from the summary I understand that it's "Waiting for #150 to make it cleaner and enable it". So should I merge it?

@rivera-ernesto
Collaborator

Yes please.

I meant that once #150 is done it will be automatically enabled for all pull requests.

@bpoplauschi bpoplauschi merged commit b3cce0c into CocoaLumberjack:master
@rivera-ernesto rivera-ernesto deleted the rivera-ernesto:travis_support branch
@bpoplauschi bpoplauschi added this to the 1.6.4 milestone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.