New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New log file is always created at app launch on simulator #464

Merged
merged 1 commit into from Mar 2, 2015

Conversation

Projects
None yet
3 participants
@benrobjoh
Contributor

benrobjoh commented Mar 1, 2015

When an app that is capable of running in the background runs on the simulator, the most recent log file is always archived, regardless of file size or age. A new log file is created on each app launch because NSFileProtectionKey is not present.

This pull request checks whether there is a value for NSFileProtectionKey in the log file's attributes. If there is no file protection value present, it will not force a new log file to be created.

Only archive the most recent log file if the NSFileProtectionKey is p…
…resent and not equal to NSFileProtectionCompleteUntilFirstUserAuthentication or NSFileProtectionNone
@rivera-ernesto

This comment has been minimized.

Member

rivera-ernesto commented Mar 2, 2015

Thanks!

rivera-ernesto added a commit that referenced this pull request Mar 2, 2015

Merge pull request #464 from benrobjoh/master
New log file is always created at app launch on simulator

@rivera-ernesto rivera-ernesto merged commit 832ba04 into CocoaLumberjack:master Mar 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bpoplauschi bpoplauschi added this to the 2.0.0 milestone Mar 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment