Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add LOGV-style macros that take a va_list. #77

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Change-Id: I4e9664dfcd3bea5dfa13ebd1bed7db9facfb901f

Mike Pontillo Add LOGV-style macros that take a va_list.
Change-Id: I4e9664dfcd3bea5dfa13ebd1bed7db9facfb901f
5976fe5
Member

rivera-ernesto commented Nov 1, 2013

I like it but maybe those should go to a separate DDLog+LOGV.h separate header file?

The reason is as not to pollute autocompletion for projects not using the macro.

Something like this.

Member

bpoplauschi commented Nov 1, 2013

+1 on using a separate header

Member

bpoplauschi commented Nov 7, 2013

@pontillo Could you update the pull request using a separate header file like @rivera-ernesto suggested?

@bpoplauschi bpoplauschi added a commit to bpoplauschi/CocoaLumberjack that referenced this pull request Nov 8, 2013

@bpoplauschi bpoplauschi Add LOGV-style macros that take a va_list. Thanks to https://github.c…
…om/pontillo for the original implementation here CocoaLumberjack#77
c06418d
Member

bpoplauschi commented Nov 8, 2013

Closing this one. Got replaced by robbiehanson#161. @pontillo thanks for the suggestion, the other pull request is in your name

@bpoplauschi bpoplauschi closed this Nov 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment