Prefixed extensions and DDMultiFormatter #85

Closed
wants to merge 4 commits into
from

Projects

None yet

3 participants

@dwlnetnl

I've prefixed the extensions with DD and add DDMultiFormatter to chain formatters.

@rivera-ernesto rivera-ernesto commented on the diff Nov 1, 2013
Lumberjack/DDLog.m
@@ -933,6 +933,36 @@ - (void)dealloc
free(queueLabel);
}
+- (id)copyWithZone:(NSZone *)zone {
+ DDLogMessage *newMessage = [DDLogMessage new];
+
+ newMessage->logLevel = message->logLevel;
rivera-ernesto
rivera-ernesto Nov 1, 2013 Member

Shouldn't message be self?

Trying to build it gives the following error:

DDLog.m:939:28: Use of undeclared identifier 'message'
Member

@dwlnetnl could you please update the pull request? It's not mergeable

Member

It would be cool to have this last pull request before 1.6.3.

Member

@rivera-ernesto seems like @dwlnetnl isn't active for a few months. We might not get an update from him. I think we can redo this pull request, but I would release 1.6.3 without it. What do you think?

Member

I think we should just release 1.6.3. There are tons of changes so I'm sure 1.6.4 will be needed soon anyway.

Member

@dwlnetnl thanks again for the idea and the implementation. Since this pull request is not valid (code doesn't compile) I created a new one. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment