New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a very basic os_log (unified logging) logger #850

Merged
merged 3 commits into from Mar 13, 2017

Conversation

Projects
None yet
6 participants
@acacio88
Copy link

acacio88 commented Mar 9, 2017

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necesarry)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues:
#765

Pull Request Description

I added a first draft of a logger which uses the new os_log API (https://developer.apple.com/reference/os/logging).

The aim is to be future proof and most of all to be able to log more than 1024chars in the device logs (see: #765)

adnacacio added some commits Mar 9, 2017

added a very basic logger that uses os_log instead of ASL and is comp…
…atible with iOS 10 (no truncated logs anymore)

@acacio88 acacio88 referenced this pull request Mar 10, 2017

Closed

iOS 10 support #765

@rivera-ernesto

This comment has been minimized.

Copy link
Member

rivera-ernesto commented Mar 10, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 11, 2017

Codecov Report

Merging #850 into master will decrease coverage by 0.44%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
- Coverage   23.07%   22.62%   -0.45%     
==========================================
  Files          16       17       +1     
  Lines        3913     3942      +29     
  Branches      279      283       +4     
==========================================
- Hits          903      892      -11     
- Misses       3008     3048      +40     
  Partials        2        2
Impacted Files Coverage Δ
Classes/DDOSLogger.m 0% <0%> (ø)
Classes/DDTTYLogger.m 18.18% <0%> (-0.88%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca61764...b7ee090. Read the comment docs.

@rivera-ernesto rivera-ernesto merged commit af2ab40 into CocoaLumberjack:master Mar 13, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 23.07%)
Details
codecov/project 22.62% (-0.45%) compared to ca61764
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@acacio88

This comment has been minimized.

Copy link

acacio88 commented Mar 14, 2017

thanks for the merge @rivera-ernesto, can the version be bumped to 3.2 ? Since I reference this pod as a dependency in a podspec, refering to the git master is not possible and a released version is needed.

@rivera-ernesto

This comment has been minimized.

Copy link
Member

rivera-ernesto commented Mar 14, 2017

Again, I leave releases to @bpoplauschi .

@acacio88

This comment has been minimized.

Copy link

acacio88 commented Mar 16, 2017

@bpoplauschi did you by any chance have time to look into this ?

@bpoplauschi

This comment has been minimized.

Copy link
Member

bpoplauschi commented Mar 19, 2017

Not yet guys, I'm a bit busy right now, but I will take a look soon.

@acacio88

This comment has been minimized.

Copy link

acacio88 commented Apr 3, 2017

bump @bpoplauschi :) ?

@judos

This comment has been minimized.

Copy link

judos commented Apr 19, 2017

Very useful change. Thanks for doing the fix @acacio88.
We would also require this change. Can you release a newer version @bpoplauschi ?

@bpoplauschi

This comment has been minimized.

Copy link
Member

bpoplauschi commented May 2, 2017

Sorry guys. I'll make it up with a new release :)

@bpoplauschi bpoplauschi added this to the 3.2.0 milestone May 3, 2017

@bpoplauschi

This comment has been minimized.

Copy link
Member

bpoplauschi commented May 3, 2017

Ok, version 3.2.0 is available. Enjoy :) and again sorry for the delay

@judos

This comment has been minimized.

Copy link

judos commented May 3, 2017

Cool, thanks @bpoplauschi ! :)

@bpoplauschi

This comment has been minimized.

Copy link
Member

bpoplauschi commented Oct 3, 2018

@acacio88 / @adnacacio Thanks a lot for showing interest and contributing to CocoaLumberjack! Even tough it’s been a while, we would like to invite you to become a maintainer – no pressure to accept! You can pitch in with what seems comfortable: comment on open issues/PRs, triage, improve documentation, write your own PRs. See a broader discussion here #941. Let me know if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment