Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A setting like USE_HEADERMAPS should be kept private. #1216

Closed
alloy opened this issue Jul 22, 2013 · 7 comments
Closed

A setting like USE_HEADERMAPS should be kept private. #1216

alloy opened this issue Jul 22, 2013 · 7 comments

Comments

@alloy
Copy link
Member

alloy commented Jul 22, 2013

Should this be handled in a configurable way, i.e. specify it in the spec, or should this simply be added to the default settings to ignore?

For more info see: #1195.

/cc @irrationalfab, @dhinviethoa
@fabiopelosin
Copy link
Member

To be clear, is the issue related to configurations affecting the user project? In any case, as the aggregate target is not compiling anything by itself, could we just add those settings in the private xcconfigs of the Pod targets?

@alloy
Copy link
Member Author

alloy commented Jul 23, 2013

To be clear, is the issue related to configurations affecting the user project?

Yup, that’s the issue.

In any case, as the aggregate target is not compiling anything by itself, could we just add those settings in the private xcconfigs of the Pod targets?

But how do we recognise which settings should go where? Because some settings are meant for the user’s project.

alloy added a commit that referenced this issue Jul 23, 2013
@alloy
[xcconfig] Always exlude USE_HEADERMAP from the user’s project. #1216
7065644
@alloy
Copy link
Member Author

alloy commented Jul 23, 2013

@dinhviethoa I’ve released version 0.22.3, which contains the above commit. Specifically, this hardcodes the USE_HEADERMAP setting from ever being included in the user’s project.

I also took the liberty to update your specs a bit to only try to configure/make after the source has been downloaded, not on subsequent installs. CocoaPods/Specs@240409d

Let me know how that works for you. I know I asked you for a sample app with a Podfile once and I think you gave me a link, but I wasn’t able to find it anymore, do you have one?

@dinhvh
Copy link

dinhvh commented Jul 23, 2013

You haven't asked me anything before ;)
However, I was also trying to set up an example but was kind of blocked by this issue.
I'll try to do that this evening (PST time).

I'll also let you know when I have a working example out.
(For now, I only checked that it built and linked properly)
I'll also have to discuss with you about a better ways to handle "configure / make" projects.
For now, it's (very^4) hard with the current state.

(It's usually also hard^2 to make a configure / make project build for iOS)

@dinhvh
Copy link

dinhvh commented Jul 25, 2013

0.22.3 worked. That's great!

Here's a link to an example of project using Cocoapods to use MailCore 2.
https://github.com/MailCore/MC2CocoaPodsSample

@fabiopelosin
Copy link
Member

Moving to #1244

fabiopelosin added a commit that referenced this issue Aug 2, 2013
@fabiopelosin
Merge branch 'master' into sandbox_reorganization_544
46c17ea 
* master: (86 commits)
  Pretty podfile-info && add license note to changelog
  add licenses & tweaks for grammar
  more copy tweaks
  Fix specs
  Fix escaping
  Fix for the xcrun commands and dirs with spaces
  update new podspec help file
  Just add license as a key to get from the specification
  [Bundle] Always add simplecov as a coveralls dependency.
  Release 0.22.3
  [Bundle] Update for 0.22.3
  Add link to ticket to TODO.
  Move license info into podfile-info command
  [CHANGELOG] Cleanup.
  [xcconfig] Always exlude `USE_HEADERMAP` from the user’s project. #1216
  [CHANGELOG] Update for 0.22.3
  Add licenses command to pod cli
  Add description of STRIP_INSTALLED_PRODUCT change to the changelog.
  Update spec to pass with the addition of the STRIP_INSTALLED_PRODUCT to the generated Pods Xcode projects.
  Add the STRIP_INSTALLED_PRODUCT buld setting to the Pods project, setting it to 'NO'. This will prevent Xcode from stripping debug symbols from the Pods libraries while performing an archive build, allowing the main project targets to include pods symbols in generated dSYMs for Archive builds.
  ...

Conflicts:
	examples/AFNetworking iOS Example/AFNetworking iOS Example.xcodeproj/project.pbxproj
	spec/integration/install_add_pod/after/Pods/Pods-JSONKit-Private.xcconfig
	spec/integration/install_add_pod/after/Pods/Pods-Reachability-Private.xcconfig
	spec/integration/install_add_pod/after/Pods/Pods-resources.sh
	spec/integration/install_add_pod/after/Pods/Pods.xcconfig
	spec/integration/install_add_pod/after/Pods/Pods.xcodeproj.yaml
	spec/integration/install_custom_workspace/after/Pods/Generated/Pods-SampleApp_1.xcconfig
	spec/integration/install_custom_workspace/after/Pods/Generated/Pods-SampleApp_2.xcconfig
	spec/integration/install_custom_workspace/after/Pods/Pods-SampleApp_1-Reachability-Private.xcconfig
	spec/integration/install_custom_workspace/after/Pods/Pods-SampleApp_2-Reachability-Private.xcconfig
	spec/integration/install_external_source/after/Pods/Pods-PodTest-Private.xcconfig
	spec/integration/install_external_source/after/execution_output.txt
	spec/integration/install_local_source/after/Pods/Pods-Reachability-Private.xcconfig
	spec/integration/install_multiple_targets/after/Pods/Generated/Pods-SampleApp_2.xcconfig
	spec/integration/install_multiple_targets/after/Pods/Generated/Pods.xcconfig
	spec/integration/install_multiple_targets/after/Pods/Pods-Reachability-Private.xcconfig
	spec/integration/install_multiple_targets/after/Pods/Pods-SampleApp_2-JSONKit-Private.xcconfig
	spec/integration/install_multiple_targets/after/Pods/Pods-SampleApp_2-Reachability-Private.xcconfig
	spec/integration/install_multiple_targets/after/Pods/Pods-test-JSONKit-Private.xcconfig
	spec/integration/install_multiple_targets/after/Pods/Pods-test.xcconfig
	spec/integration/install_new/after/Pods/Generated/Pods.xcconfig
	spec/integration/install_new/after/Pods/Pods-Reachability-Private.xcconfig
	spec/integration/install_podfile_callbacks/after/Pods/Pods-Reachability-Private.xcconfig
	spec/integration/install_podspec/after/Pods/Generated/Pods.xcconfig
	spec/integration/install_podspec/after/Pods/Pods-Reachability-Private.xcconfig
	spec/integration/install_remove_pod/after/Pods/Pods-Reachability-Private.xcconfig
	spec/integration/install_remove_pod/after/Pods/Pods-resources.sh
	spec/integration/install_remove_pod/after/Pods/Pods.xcconfig
	spec/integration/install_remove_pod/after/Pods/Pods.xcodeproj.yaml
	spec/integration/install_spec_callbacks/after/Pods/Generated/Pods.xcconfig
	spec/integration/install_spec_callbacks/after/Pods/Pods-Reachability-Private.xcconfig
	spec/integration/install_spec_callbacks/after/Pods/Pods.xcconfig
	spec/integration/install_subspecs/after/Pods/Pods-OS X App-PodTest-Private.xcconfig
	spec/integration/install_subspecs/after/Pods/Pods-iOS App-PodTest-Private.xcconfig
	spec/integration/install_subspecs/after/execution_output.txt
	spec/integration/update/after/Pods/Generated/Pods.xcconfig
	spec/integration/update/after/Pods/Pods-Reachability-Private.xcconfig
	spec/integration/update/after/Pods/Pods-resources.sh
	spec/integration/update/after/Pods/Pods.xcconfig
	spec/integration/update/after/Pods/Pods.xcodeproj.yaml
	spec/unit/hooks/library_representation_spec.rb
jzapater pushed a commit to jzapater/CocoaPods that referenced this issue Sep 17, 2013
@keith
Merge pull request CocoaPods#1216 from tcurdt/master
2707622 
please add TCLocalizer 1.0.0
@Whirlwind
Copy link
Contributor

Whirlwind commented May 30, 2018 •
edited

I found this logic had been removed in the master branch, is it a bug?

This was referenced May 30, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alloy @dinhvh @fabiopelosin @Whirlwind