Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

cocoapods 0.26.1 installs non-arc code into arc project #1454

Closed
amccarri opened this Issue Oct 8, 2013 · 9 comments

Comments

Projects
None yet
8 participants
Contributor

amccarri commented Oct 8, 2013

Steps:

1 - create an arc project
2 - add Facebook SDK pod (3.8.0 in our case)
3 - attempt build

Tons of arc failures.

4 - downgrade to 0.25.0
5 - build again -- success.

huguesbr commented Oct 8, 2013

+1

lexrus commented Oct 9, 2013

+1

chrishol commented Oct 9, 2013

+1

Owner

fabiopelosin commented Oct 9, 2013

I've just tested this following the steps of the original post and I can't reproduce the issue.

The Pod project is formed as expected, taking into account that Facebook-iOS-SDK 3.8.0 doesn't use ARC. The settings of the Pods-Test-Facebook-iOS-SDK target are:

  • Objective-C Automatic Reference Counting: No (inherited from the Pod project).
  • Any file compiled by that target doesn't include any ARC compiler flag (they are all blank).

The library is linked fine by the Pods aggregate library and by the client target (iOS Application using ARC) as expected. The tests where performed by Xcode 5.

In future please include the failing target and the exact build error reported by Xcode or xcodebuild.

chrishol commented Oct 9, 2013

In my workspace, the Pods project has use ARC (CLANG_ENABLE_OBJC_ARC) set to No for my "Debug" and "Release" configurations and Yes for everything else (I have quite a number of custom configurations).

Rolling back to 0.25.0, which builds correctly, this is set to No across the board.

itsthejb commented Oct 9, 2013

+1! Xcode 4.6.3 here

x2on commented Oct 9, 2013

Same here for Xcode 5. All pods have ARC disabled for Debug and Release and all other are enabled.

+1 , using XCode 5

Owner

fabiopelosin commented Oct 9, 2013

Thanks @chrishol for the detailed report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment