Move accessory features of CocoaPods to plugins #1589

Closed
fabiopelosin opened this Issue Nov 13, 2013 · 14 comments

Comments

Projects
None yet
3 participants
@fabiopelosin
Member

fabiopelosin commented Nov 13, 2013

One good candidate is the $ pod podfile-info command.

@Kapin

This comment has been minimized.

Show comment
Hide comment
@Kapin

Kapin Nov 13, 2013

Member

@irrationalfab should these be hosted under the Cocoapods banner or personal repos? Since they are already in the project I think the former might make more sense.

Member

Kapin commented Nov 13, 2013

@irrationalfab should these be hosted under the Cocoapods banner or personal repos? Since they are already in the project I think the former might make more sense.

@fabiopelosin

This comment has been minimized.

Show comment
Hide comment
@fabiopelosin

fabiopelosin Nov 13, 2013

Member

I would prefer to keep those plugins under the CocoaPods organization because in this way the Core team has push access. However if you somebody would like to maintain one of them, depending on the feature, I'm open to discuss it.

Member

fabiopelosin commented Nov 13, 2013

I would prefer to keep those plugins under the CocoaPods organization because in this way the Core team has push access. However if you somebody would like to maintain one of them, depending on the feature, I'm open to discuss it.

@fabiopelosin

This comment has been minimized.

Show comment
Hide comment
@fabiopelosin

fabiopelosin Nov 13, 2013

Member

Also GitHub integration could be moved out, the main reason for moving it out (gem dependencies) is not very strong. However moving it to a dedicated plugin could enable workflows much more oriented to GitHub (i.e. pull requests).

Member

fabiopelosin commented Nov 13, 2013

Also GitHub integration could be moved out, the main reason for moving it out (gem dependencies) is not very strong. However moving it to a dedicated plugin could enable workflows much more oriented to GitHub (i.e. pull requests).

@Kapin

This comment has been minimized.

Show comment
Hide comment
@Kapin

Kapin Nov 15, 2013

Member

First stab at porting it. Still needs a bunch of work and we need to move it under the CocoaPods banner (and credit whoever added it originally properly), but it's on the right track. https://github.com/Kapin/podfile_info

Member

Kapin commented Nov 15, 2013

First stab at porting it. Still needs a bunch of work and we need to move it under the CocoaPods banner (and credit whoever added it originally properly), but it's on the right track. https://github.com/Kapin/podfile_info

@fabiopelosin

This comment has been minimized.

Show comment
Hide comment
@fabiopelosin

fabiopelosin Nov 16, 2013

Member

👍

Member

fabiopelosin commented Nov 16, 2013

👍

@fabiopelosin

This comment has been minimized.

Show comment
Hide comment
@fabiopelosin

fabiopelosin Nov 16, 2013

Member

To move to the CocoaPods organization you should be able to just transfer the repo.

Member

fabiopelosin commented Nov 16, 2013

To move to the CocoaPods organization you should be able to just transfer the repo.

@Kapin

This comment has been minimized.

Show comment
Hide comment
@Kapin

Kapin Nov 27, 2013

Member

@irrationalfab I need admin rights to do that. I've added you as a collaborator to the repo so we can sync up to transfer it properly.

Member

Kapin commented Nov 27, 2013

@irrationalfab I need admin rights to do that. I've added you as a collaborator to the repo so we can sync up to transfer it properly.

@fabiopelosin

This comment has been minimized.

Show comment
Hide comment
@fabiopelosin

fabiopelosin Nov 28, 2013

Member

I did and experiment and just forked it. I don't know if now you can transfer the ownership or what happens if you delete yours. However I would even be comfortable keeping the fork as a tribute for the great work! Thoughts?

Member

fabiopelosin commented Nov 28, 2013

I did and experiment and just forked it. I don't know if now you can transfer the ownership or what happens if you delete yours. However I would even be comfortable keeping the fork as a tribute for the great work! Thoughts?

@xslim

This comment has been minimized.

Show comment
Hide comment
@xslim

xslim Dec 4, 2013

Contributor

As a person who initially commited this code to cocoapods I think it's better if @Kapin will just transfer a repo to CocoaPods organization...

Contributor

xslim commented Dec 4, 2013

As a person who initially commited this code to cocoapods I think it's better if @Kapin will just transfer a repo to CocoaPods organization...

@fabiopelosin

This comment has been minimized.

Show comment
Hide comment
@fabiopelosin

fabiopelosin Dec 4, 2013

Member

@xslim Ouch... sorry about this. It is my fault as I didn't consider that this patch was contributed by you when I decided to fork. I'm all about properly crediting people and I consider not doing so no cool at all. We will fix this before releasing it by:

  • Prepending your name in the license.
  • List you as the author in the gemspec.
  • Transfer the repo instead of forking.

I have also to point, for clarity, out that in another discussion @Kapin stated that he was looking for a way to properly credit you (another issue or in the CocoaPods Campfire).

Also as we prefer to keep the CocoaPods gem lean while allowing the community to customize it with plugins, I was wondering if you would like to have this repo transferred to you. I think that this could be a great solution as you have a stronger incentive to evolve this subcommand and you would properly preserve all the credits.

Member

fabiopelosin commented Dec 4, 2013

@xslim Ouch... sorry about this. It is my fault as I didn't consider that this patch was contributed by you when I decided to fork. I'm all about properly crediting people and I consider not doing so no cool at all. We will fix this before releasing it by:

  • Prepending your name in the license.
  • List you as the author in the gemspec.
  • Transfer the repo instead of forking.

I have also to point, for clarity, out that in another discussion @Kapin stated that he was looking for a way to properly credit you (another issue or in the CocoaPods Campfire).

Also as we prefer to keep the CocoaPods gem lean while allowing the community to customize it with plugins, I was wondering if you would like to have this repo transferred to you. I think that this could be a great solution as you have a stronger incentive to evolve this subcommand and you would properly preserve all the credits.

@xslim

This comment has been minimized.

Show comment
Hide comment
@xslim

xslim Dec 4, 2013

Contributor

Hi!
No worries:) I'm not seeking credits)))
And there's no need to transfer the repo to me)
You can just add me as contributor there.

Sent from my iPhone

On 4 dec. 2013, at 19:00, Fabio Pelosin notifications@github.com wrote:

@xslim Ouch... sorry about this. It is my fault as I didn't consider that this patch was contributed by you when I decided to fork. I'm all about properly crediting people and I consider not doing so no cool at all. We will fix this before releasing it by:

Prepending your name in the license.
List you as the author in the gemspec.
Transfer the repo instead of forking.
I have also to point, for clarity, out that in another discussion @Kapin stated that he was looking for a way to properly credit you (another issue or in the CocoaPods Campfire).

Also as we prefer to keep the CocoaPods gem lean while allowing the community to customize it with plugins, I was wondering if you would like to have this repo transferred to you. I think that this could be a great solution as you have a stronger incentive to evolve this subcommand and you would properly preserve all the credits.


Reply to this email directly or view it on GitHub.

Contributor

xslim commented Dec 4, 2013

Hi!
No worries:) I'm not seeking credits)))
And there's no need to transfer the repo to me)
You can just add me as contributor there.

Sent from my iPhone

On 4 dec. 2013, at 19:00, Fabio Pelosin notifications@github.com wrote:

@xslim Ouch... sorry about this. It is my fault as I didn't consider that this patch was contributed by you when I decided to fork. I'm all about properly crediting people and I consider not doing so no cool at all. We will fix this before releasing it by:

Prepending your name in the license.
List you as the author in the gemspec.
Transfer the repo instead of forking.
I have also to point, for clarity, out that in another discussion @Kapin stated that he was looking for a way to properly credit you (another issue or in the CocoaPods Campfire).

Also as we prefer to keep the CocoaPods gem lean while allowing the community to customize it with plugins, I was wondering if you would like to have this repo transferred to you. I think that this could be a great solution as you have a stronger incentive to evolve this subcommand and you would properly preserve all the credits.


Reply to this email directly or view it on GitHub.

@fabiopelosin

This comment has been minimized.

Show comment
Hide comment
@fabiopelosin

fabiopelosin Dec 4, 2013

Member

Cool! Thanks for understanding!

Member

fabiopelosin commented Dec 4, 2013

Cool! Thanks for understanding!

@Kapin

This comment has been minimized.

Show comment
Hide comment
@Kapin

Kapin Dec 6, 2013

Member

@xslim the published gem's repo is here https://github.com/cocoapods/cocoapods-podfile_info. If you would like to do a pass over and see if I missed anything, it would be totally awesome 😺

Member

Kapin commented Dec 6, 2013

@xslim the published gem's repo is here https://github.com/cocoapods/cocoapods-podfile_info. If you would like to do a pass over and see if I missed anything, it would be totally awesome 😺

@fabiopelosin

This comment has been minimized.

Show comment
Hide comment
@fabiopelosin

fabiopelosin Dec 9, 2013

Member

Closing as there are no other suggestions for the moment.

Member

fabiopelosin commented Dec 9, 2013

Closing as there are no other suggestions for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment