-isystem and -iquote compiler flags appear incorrect #1862

Closed
bromoab opened this Issue Mar 6, 2014 · 4 comments

Projects

None yet

4 participants

@bromoab
bromoab commented Mar 6, 2014

Some of the -isystem and -iquote compiler flags appear to be formatted incorrectly. There is not a space between the flag name and the include path in some cases. For example,

-iquotePods/Headers/RSColorPicker

Running pod version 0.29.0

Here is copy of the Xcode Log Navigator output formatted for easier reading of the compiler flags.

CompileC /Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Tennis\ Tally.build/Objects-normal/i386/TTTallyViewController.o Tennis\ Tally/TTTallyViewController.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler
    cd "/Users/bromo/SWDevelopment/iOS/ICare/Tennis Tally"
    setenv LANG en_US.US-ASCII
    setenv PATH "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin"
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
    -x objective-c
    -arch i386
    -fmessage-length=0
    -fdiagnostics-show-note-include-stack
    -fmacro-backtrace-limit=0
    -std=gnu99
    -fobjc-arc
    -Wno-trigraphs
    -fpascal-strings
    -O0
    -Wno-missing-field-initializers
    -Wno-missing-prototypes
    -Wno-implicit-atomic-properties
    -Wno-receiver-is-weak
    -Wno-arc-repeated-use-of-weak
    -Wduplicate-method-match
    -Wno-missing-braces
    -Wparentheses
    -Wswitch
    -Wno-unused-function
CompileC /Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Tennis\ Tally.build/Objects-normal/i386/TTTallyViewController.o Tennis\ Tally/TTTallyViewController.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler
    cd "/Users/bromo/SWDevelopment/iOS/ICare/Tennis Tally"
    setenv LANG en_US.US-ASCII
    setenv PATH "/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin"
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
    -x objective-c
    -arch i386
    -fmessage-length=0
    -fdiagnostics-show-note-include-stack
    -fmacro-backtrace-limit=0
    -std=gnu99
    -fobjc-arc
    -Wno-trigraphs
    -fpascal-strings
    -O0
    -Wno-missing-field-initializers
    -Wno-missing-prototypes
    -Wno-implicit-atomic-properties
    -Wno-receiver-is-weak
    -Wno-arc-repeated-use-of-weak
    -Wduplicate-method-match
    -Wno-missing-braces
    -Wparentheses
    -Wswitch
    -Wno-unused-function
    -Wno-unused-label    -Wno-unused-parameter
    -Wunused-variable    -Wunused-value
    -Wempty-body
    -Wuninitialized
    -Wno-unknown-pragmas
    -Wno-shadow
    -Wno-four-char-constants
    -Wno-conversion
    -Wconstant-conversion
    -Wint-conversion
    -Wno-bool-conversion
    -Wenum-conversion
    -Wno-shorten-64-to-32
    -Wpointer-sign
    -Wno-newline-eof
    -Wno-selector
    -Wno-strict-selector-match
    -Wno-undeclared-selector
    -Wno-deprecated-implementations    -DDEBUG=1
    -DCOCOAPODS=1    -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator7.0.sdk
    -fexceptions
    -fasm-blocks
    -fstrict-aliasing
    -Wprotocol
    -Wdeprecated-declarations
    -g
    -Wno-sign-conversion
    -fobjc-abi-version=2
    -fobjc-legacy-dispatch
    -mios-simulator-version-min=7.0
    -iquote /Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Te
nnis\ Tally.build/Tennis\ Tally-generated-files.hmap
    -I/Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Tennis\ 
Tally.build/Tennis\ Tally-own-target-headers.hmap
    -I/Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Tennis\ 
Tally.build/Tennis\ Tally-all-target-headers.hmap
    -iquote /Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Te
nnis\ Tally.build/Tennis\ Tally-project-headers.hmap
    -iquotePods/Headers
    -iquotePods/Headers/RSColorPicker
    -I/Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Products/Debug-iphonesimulator/include
    -I/Users/bromo/SWDevelopment/iOS/ICare/Tennis\ Tally/Pods/Headers
    -I/Users/bromo/SWDevelopment/iOS/ICare/Tennis\ Tally/Pods/Headers/RSColorPicker
    -I/Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Tennis\ Tally.build/DerivedSources/i386
    -I/Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Tennis\ Tally.build/DerivedSources
    -fdiagnostics-show-option
    -Wall
    -Wextra
    -Wcast-align
    -Wconversion
    -Wfloat-equal
    -Wformat=2
    -Wimplicit-atomic-properties
    -Wmissing-declarations
    -Wmissing-prototypes
    -Woverlength-strings
    -Wshadow
    -Wstrict-selector-match
    -Wundeclared-selector
    -Wunreachable-code
    -Wno-unused-parameter
    -F/Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Products/Debug-iphonesimulator
    -isystem/Users/bromo/SWDevelopment/iOS/ICare/Tennis\ Tally/Pods/Headers
    -isystem/Users/bromo/SWDevelopment/iOS/ICare/Tennis\ Tally/Pods/Headers/RSColorPicker
    -include /Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/PrecompiledHeaders/Tennis\ Tally-Prefix-egdaqgtcedrhzrbmdxtiwlniqcmb/Tennis\ Tally-Prefix.pch
    -MMD
    -MT dependencies
    -MF /Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Tennis\ Tally.build/Objects-normal/i386/TTTallyViewController.d
    --serialize-diagnostics /Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Tennis\ Tally.build/Objects-normal/i386/TTTallyViewController.dia
    -c /Users/bromo/SWDevelopment/iOS/ICare/Tennis\ Tally/Tennis\ Tally/TTTallyViewController.m
    -o /Users/bromo/Library/Developer/Xcode/DerivedData/Tennis_Tally-eddfuwlvfcrrhdfnoloifwpzxowc/Build/Intermediates/Tennis\ Tally.build/Debug-iphonesimulator/Tennis\ Tally.build/Objects-normal/i386/TTTallyViewController.o
@kylef kylef added a commit that referenced this issue Mar 16, 2014
@kylef kylef Include a space between `-isystem` and the directory
According to clang's help it should have a space.

    -isystem <directory>    Add directory to SYSTEM include search path

Closes #1862
b1cb6f7
@CocoaPodsBot
Collaborator

Issue has been confirmed by @neonichu

@bromoab bromoab assigned CocoaPodsBot and unassigned CocoaPodsBot Mar 29, 2014
@kylef kylef self-assigned this Mar 30, 2014
@kylef
kylef commented Mar 30, 2014

@irrationalfab I'm correct in thinking -iquote isn't used in CocoaPods right? (maybe it was in the past?)

@alloy
Member
alloy commented Mar 30, 2014

I have at least never seen it pass by. As @swizzlr implemented the -isystem stuff, he might know?

@kylef
kylef commented Mar 30, 2014

Closing, moving discussion to #1894

@kylef kylef closed this Mar 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment