Showing deprecation warnings during the installation #2003

Closed
fabiopelosin opened this Issue Apr 2, 2014 · 7 comments

Comments

Projects
None yet
2 participants
Owner

segiddins commented Apr 14, 2014

@irrationalfab should pod outdated also report deprecated pods?

Owner

segiddins commented Apr 14, 2014

Also, where would be the best place to implement this? Somewhere in the analyzer?

Owner

fabiopelosin commented Apr 14, 2014

@segiddins I would add a new method here (something like perform_post_install_actions) which would check for deprecations (and in future it would be used to send the install information to provide download counts).

👍 for pod outdated.

Owner

segiddins commented Apr 14, 2014

@irrationalfab just deprecated root specs or all deprecated specs?

Owner

fabiopelosin commented Apr 14, 2014

I would map all the specs to their root and them uniq them. Then I would print a warning per specification. I prefer this approach because the deprecations attribute are root ones and thus refer to the spec as a whole.

Owner

segiddins commented Apr 14, 2014

root_specs does exactly that. I think I misunderstood what root meant. Will have a PR in a few minutes

Owner

fabiopelosin commented Apr 14, 2014

Ace!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment