trunk TODOs #2151

Closed
alloy opened this Issue May 19, 2014 · 18 comments

Comments

Projects
None yet
5 participants
Owner

alloy commented May 19, 2014

  • Completely remove Ruby hooks from podspec. (post_install, pre_install)
  • Disallow push to master repo if it’s CocoaPods/Specs repo and tell the user to use pod trunk push instead. puts 'Use pod trunk push!' if name == 'master' && remote == 'https://github.com/CocoaPods/Specs.git'
  • Move pod push to pod repo push and temp forward from pod push plus show a warning to the user that the command has moved.
  • Make prepare_command show the output in case it failed. Otherwise the user will have to know to use --verbose and this makes it feel like too opaque. (Specifically for this issue: CocoaPods/trunk.cocoapods.org#55)

@alloy alloy referenced this issue in CocoaPods/cocoapods-trunk May 19, 2014

Closed

Verify that the repo being pushed to is actually our spec repo. #4

Contributor

AliSoftware commented May 19, 2014

Will cocoapods-trunk be installed by default as a dependency to the cocoapods gem (like cocoapods-try and cocoapods-plugins)?
(If not we should also ensure it is installed / suggest in the error messages to install the gem)

Owner

orta commented May 19, 2014

Contributor

AliSoftware commented May 19, 2014

Cool. For the second point, we shouldn't base our test on the name of the repo at all.

One may rename ~/.cocoapods/repos/master to ~/.cocoapods/repos/offcial or whatnot if one feels like and it should still warn when then we pod push official. Only the remote URL should suffice to be tested to lead to the warning message about using pod trunk push instead, right?

fabiopelosin added a commit that referenced this issue May 19, 2014

Owner

fabiopelosin commented May 19, 2014

@AliSoftware up to today the tests has been based on the name of the repo. I consider this a temporary solution to inform users about the pod trunk push command which doesn't removes any need of disambiguation.

Owner

floere commented May 19, 2014

(Removed since the comment made no sense whatsoever – obviously these are trunk pre-launch items)

fabiopelosin added a commit that referenced this issue May 19, 2014

Owner

fabiopelosin commented May 19, 2014

Move pod push to pod repo push and temp forward from pod push plus show a warning to the user that the command has moved.

Maybe in future we should move out the pod repo stuff to pod pod private-repo and make it a plugin .

Contributor

AliSoftware commented May 19, 2014

@irrationalfab 👍 that would make sense.
Maybe not call it "repo" then, but private-trunk or whatnot?

Owner

fabiopelosin commented May 19, 2014

private-trunk is cute!

Contributor

AliSoftware commented May 19, 2014

So pod repo push and no pod private-trunk push then?

Owner

orta commented May 19, 2014

I'm not a fan of private-trunk, people won't be having their own private trunks they'll be having spec repos. Trunk is for the ACL.

Owner

fabiopelosin commented May 19, 2014

@kylef: The prepare command is working correctly!

@fabiopelosin fabiopelosin referenced this issue May 19, 2014

Merged

Trunk #2153

Contributor

AliSoftware commented May 19, 2014

Ok, good point.

Does the pod repo command will really have subcommands other than push? I don't think so, so maybe we should make it a plugin and name it pod private-repo-push or sthg?

(yes, I know, perfectionist and master of consistency speaking here 😆)

Owner

fabiopelosin commented May 19, 2014

It has important subcommands which are useful to only a subset of the users (those maintaing a private repo, which I estimate to be less than 20%). So I propose to move it to a dedicated plugin.

$ dpod repo --help
Usage:

    $ pod repo

      Manage spec-repositories

Commands:

    + add       Add a spec repo.
    + lint      Validates all specs in a repo.
    + push      Push new specifications to a spec-repo
    + remove    Remove a spec repo
    + update    Update a spec repo.

Options:

    --silent    Show nothing
    --verbose   Show more debugging information
    --no-ansi   Show output without ANSI codes
    --help      Show help banner of specified command
Owner

orta commented May 19, 2014

^ (edited)
I agree with @irrationalfab

Owner

fabiopelosin commented May 19, 2014

(note to self: remove all the dots form the descriptions)

Contributor

AliSoftware commented May 19, 2014

Nice, didn't think of all those possible subcommands :)

Will be very useful to me (as I'm actually using a private repo here at work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment