Current resource bundle target setup doesn't play well with image assets containing universal images

[nikolaykasyanov]

I have an asset catalog with universal image set (I'm using different images for iPhone and iPad) included in pod resource bundle like this:

s.resource_bundle = {'LibName' => ['LibName/Media.xcassets']}

And here's the problem: build setting "Targeted Device Family" of LibName resource bundle target is set to iPhone, so I got no iPad images in resulting LibName.bundle.

I think that target device family should be inferred from the application target device family or user should be able to specify target device family in podfile so podspecs could inherit this setting.

[nikolaykasyanov]

As far as I understand, the fix could be trivial, we just should take spec consumer target device family here: https://github.com/CocoaPods/CocoaPods/blob/master/lib/cocoapods/installer/target_installer/pod_target_installer.rb#L68

I'd be happy to provide a fix but I need some guidance.

[alloy]

Yeah that sounds about right, although I don’t believe we actually collect from the user’s project for what device(s) it builds atm, so the Analyser would have to be extended to fetch that info.

[nikolaykasyanov]

@alloy thanks for the info.

I just realized that there's not so much sense in supporting asset catalogs inside resource bundles after everyone moves to deployment target >= 7.0, because it seems impossible to load anything from the Assets.car located inside resource bundle.

[fabiopelosin]

So should this issue be closed?

[nikolaykasyanov]

@irrationalfab if so, resource bundles with xcassets should be deprecated as well.

[fabiopelosin]

I just realized that there's not so much sense in supporting asset catalogs inside resource bundles after everyone moves to deployment target >= 7.0, because it seems impossible to load anything from the Assets.car located inside resource bundle.

@Corristo, as the discussion is not completely clear to me, can you clarify this sentence?

[nikolaykasyanov]

@irrationalfab actool compiles *.xcassets contents to Assets.car blob if project deployment target is 7.0 or higher.

It seems that only Assets.car from application bundle root is considered by iOS when calling +imageNamed:, so it makes no sense to create resource bundles with Assets.car inside, you won't be able to load anything from it.

[nikolaykasyanov]

Update to my previous comment:
Looks like it's possible to access images compiled to Assets.car in a bundle using method introduced in iOS 8 +[UIImage imageNamed:inBundle:compatibleWithTraitCollection:]

[onekiloparsec]

Hi. Not sure what's the status of this, but the problem still exists.I am using 0.36.0 right now, and I have libraries with resources bundles containing not images but xibs. Once the Pods project is integrated into the client project, the "Target Device Family" setting of the Pods root project is blank (i.e. not iPhone, not iPad, and not iPhone/iPad). Upon building, resources get created for iPhone only. Selecting "iPhone/iPad" in the build setting of the Pods project fixes the problem, at least manually. But it has to be done every time we update the pods of the project. A thing that occurs many times when you are using the pods your are currently developing for an app. If I could provide help, I would be happy to do so.

[levigroker]

This is also happening for me with a storyboard. I'm using Xcode 6.3.1 targeting iOS 7.0 and up. My pod has a storyboard in it which recently does not show up for the iPad (but did previous to 6.3 and 8.3).

[levigroker]

Well, a workaround is to manually specify the desired Targeted Device Families in the post_install hook:

post_install do |installer_representation|
  # Directly set the Targeted Device Family
  # See https://github.com/CocoaPods/CocoaPods/issues/2292
  installer_representation.project.build_configurations.each do |config|
    config.build_settings['TARGETED_DEVICE_FAMILY'] = '1,2'
  end
end

See Apple's XcodeBuildSettingRef for specifics about TARGETED_DEVICE_FAMILY.

Essentially:

1: iPhone/iPod touch.
2: iPad.

It would be preferable for CocoaPods to inherit the targeted device family of the hosting Project's Targets, if possible.

Levi

[knox]

Based on levi's idea i am using the following post_install hook

post_install do |installer|
  installer.project.targets.each do |target|
    next unless target.product_type == 'com.apple.product-type.bundle'
    target.build_configurations.each do |config|
      #config.build_settings['TARGETED_DEVICE_FAMILY'] = '1,2' # iPhone, iPad
      config.build_settings['TARGETED_DEVICE_FAMILY'] = '2'
    end
  end
end

[bvibber]

Note that the above fails on 0.38 beta -- must use installer.pods_project instead of installer.project.

This works for me, but is a bit verbose:

post_install do |installer|
  if installer.respond_to?(:project)
    project = installer.project
  else
    project = installer.pods_project
  end
  project.targets.each do |target|
    if target.product_reference.name == 'OGVKitResources.bundle' then
      target.build_configurations.each do |config|
        config.build_settings['TARGETED_DEVICE_FAMILY'] = '1,2' # iPhone, iPad
      end
    end
  end
end