Move Xcode project lib code into its own gem. #24

Closed
alloy opened this Issue Oct 12, 2011 · 13 comments

Projects

None yet

2 participants

@alloy
Member
alloy commented Oct 12, 2011

No description provided.

@nolanw
Contributor
nolanw commented Oct 25, 2011

Let's do this after eliminating the project templates (which will heavily rely on the xcodeproj code), as it shouldn't churn so much by then.

@alloy
Member
alloy commented Nov 6, 2011

Things like the PBXProject and framework definition in https://github.com/alloy/cocoapods/blob/master/lib/cocoapods/project_template.rb should first be moved into the Xcode::Project class.

The same applies to the code that configures the user’s project in installer.rb.

@nolanw
Contributor
nolanw commented Nov 7, 2011

Done as of 7d64004, along with some super powers for PBXFileReference. Anything else obviously need doing before splitting off to a gem?

@alloy
Member
alloy commented Nov 7, 2011

Cool. I think the majority of the project_template.rb code will have to move out to the Xcode gem, but no more small things like the above afaik.

@alloy
Member
alloy commented Nov 7, 2011

I was a bit unimaginative this morning, so if you have an idea for a better name let me know, for now I have created a repo called xcode-builder, you have push access. Do you want me to do the initial moving out, or do you want to work on that?

@nolanw
Contributor
nolanw commented Nov 8, 2011

I'll get to it sometime this week unless you beat me to it.

I would've called it "xcodeproj", so pick your favourite :-)

@alloy
Member
alloy commented Nov 8, 2011

Works for me https://github.com/alloy/xcodeproj :)

Btw, I also want to move the workspace and xcconfig code out into the gem.

@nolanw
Contributor
nolanw commented Nov 8, 2011

Right, I just think it's a cool name. "xcodeproj_with_xcworkspace_and_xcconfig" is less so.

On 2011-11-08, at 2:24 AM, Eloy Durán wrote:

Works for me https://github.com/alloy/xcodeproj :)

Btw, I also want to move the workspace and xcconfig code out into the gem.


Reply to this email directly or view it on GitHub:
https://github.com/alloy/cocoapods/issues/24#issuecomment-2665370

@alloy
Member
alloy commented Nov 8, 2011

lol, my remark about those classes was unrelated to the gem name.

@nolanw
Contributor
nolanw commented Nov 11, 2011

All set in the xcodeproj-gem branch once you've pushed the xcodeproj gem. (The one failing spec is, I think, yours.)

@alloy
Member
alloy commented Nov 11, 2011

Great work! I’ll have a look at the failure tonight and go through the code one last time, then push.

@alloy
Member
alloy commented Nov 11, 2011

I think we’ll have to rename the namespace module to reflect the name of the gem, i.e. Xcode => Xcodeproj

@alloy alloy closed this in 2ab89bd Nov 12, 2011
@alloy
Member
alloy commented Nov 12, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment