Skip to content
This repository

Inhibit warnings on a per-pod basis #674

Closed
lukeredpath opened this Issue December 03, 2012 · 7 comments

4 participants

Luke Redpath Eloy Durán Marin Usalj Fabio Pelosin
Luke Redpath
Owner

The inhibit_all_warnings! option lets me suppress warnings from the Pods target, but I'd much rather be able to do this on a per-Pod basis.

Reasoning: warnings from Pods are annoying as they aren't easily fixed, but I'd rather not just blanket suppress them without knowing if they are important or not, especially when adding new pods.

Having determined a Pod's warnings aren't serious, I'd then like to be able to disable warnings for just that pod.

Eloy Durán
Owner

Reasoning: warnings from Pods are annoying as they aren't easily fixed, but I'd rather not just blanket suppress them without knowing if they are important or not, especially when adding new pods.

Agreed.

This is also why we don’t enable the inhibit option by default, but once enabled and adding new pods afterwards it becomes too easy to not see potential harmful warnings.

Marin Usalj
Collaborator

What's the proposed syntax for this?

one option is per pod:

pod 'ObjectiveSugar', show_warnings: false # Maybe show is a better term

another one

inhibit_warnings ['ObjectiveSugar', 'QuickDialog']
Fabio Pelosin

@mneorr

Here's how I do it now:

If you pan to work on this feature please use the 0.17 branch (experimental docs), as it is quite different because it has been refactored (for example see CocoaPods/Core).

What's the proposed syntax for this?

The syntax that you are proposing is not bad. Originally I had in mind something like the third one and at the moment I don't have a strong opinion about those two alternatives. However I would exclude the second because there are already too many of options for pod DSL command.

Marin Usalj
Collaborator

@irrationalfab okay sure

Eloy Durán
Owner

@mneorr I prefer the first one, it will also be much easier to see at a glance which pods have been covered. For consistency sake (with the existing build setting name) I would, however, opt for inhibit_warnings instead of show_warnings.

Marin Usalj
Collaborator

@alloy okay, makes sense.

Then, I guess this is the final syntax:

pod 'ObjectiveSugar', inhibit_warnings: true 
Eloy Durán
Owner

@mneorr Yessir.

Fabio Pelosin irrationalfab referenced this issue March 09, 2013
Closed

Isolate Pods in dedicated targets #841

1 of 3 tasks complete
Marin Usalj supermarin closed this in f90c28c April 06, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.