New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPANDED_CODE_SIGN_IDENTITY: unbound variable #8000

Closed
ZevEisenberg opened this Issue Aug 10, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@ZevEisenberg

ZevEisenberg commented Aug 10, 2018

Report

What did you do?

bundle exec pod lib lint --no-clean --verbose

What did you expect to happen?

The pod lints cleanly.

What happened instead?

Linting fails with:

/var/folders/j_/86_9xkgj0pqc0q2h5xx_9lt40000gn/T/CocoaPods-Lint-20180810-16542-1ru5jza-BonMot/Pods/Target Support Files/Pods-App/Pods-App-frameworks.sh: line 104: EXPANDED_CODE_SIGN_IDENTITY: unbound variable
Command PhaseScriptExecution failed with a nonzero exit code

This seems to be some kind of weird regression of #7708, which appears to have been fixed prior to the release of CocoaPods 1.5.3, but when I look at the contents of the Pods-App-frameworks.sh script mentioned in the error message, it contains if [ -n "${EXPANDED_CODE_SIGN_IDENTITY}" instead of the version from that issue/PR, which should look like if [ -n "${EXPANDED_CODE_SIGN_IDENTITY:-}".

CocoaPods Environment

Stack

   CocoaPods : 1.5.3
        Ruby : ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin17]
    RubyGems : 2.6.14
        Host : Mac OS X 10.13.6 (17G65)
       Xcode : 10.0 (10L221o)
         Git : git version 2.18.0
Ruby lib dir : /Users/zev/.rvm/rubies/ruby-2.4.1/lib
Repositories : master - https://github.com/CocoaPods/Specs.git @ 00eaf927d5829980d5afde43770d32c23086099a

Installation Source

Executable Path: /Users/zev/.rvm/gems/ruby-2.4.1/bin/pod

Plugins

claide-plugins        : 0.9.2
cocoapods-deintegrate : 1.0.2
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.0.0
cocoapods-trunk       : 1.3.0
cocoapods-try         : 1.1.0
slather               : 2.4.6

Project that demonstrates the issue

Raizlabs/BonMot#344 as of commit Raizlabs/BonMot@8300727

@ZevEisenberg

This comment has been minimized.

ZevEisenberg commented Aug 10, 2018

Oh, and you can see the error log from a build in situ at https://circleci.com/gh/Raizlabs/BonMot/612

@dnkoutso

This comment has been minimized.

Contributor

dnkoutso commented Aug 10, 2018

Thanks for the report, can you try master?

@dnkoutso

This comment has been minimized.

Contributor

dnkoutso commented Aug 10, 2018

Seems like that fix is in 1.6.0 not 1.5.3. So I believe master should work for you.

@ZevEisenberg

This comment has been minimized.

ZevEisenberg commented Aug 10, 2018

Oops, totally missed the milestone flag. Checking.

@ZevEisenberg

This comment has been minimized.

ZevEisenberg commented Aug 10, 2018

That worked. Is there a timeline for 1.6? Specifically, do you think it will be before/around the time of Xcode 10 going GM? The work I'm doing on this branch is for Xcode 10 compatibility.

ZevEisenberg added a commit to Raizlabs/BonMot that referenced this issue Aug 10, 2018

@dnkoutso

This comment has been minimized.

Contributor

dnkoutso commented Aug 10, 2018

Actually we are probably days away from shipping 1.6.0.beta.1 (no promises). A blog post is ready CocoaPods/blog.cocoapods.org#154

Thank you for confirming though!

@dnkoutso dnkoutso closed this Aug 10, 2018

ZevEisenberg added a commit to Raizlabs/Anchorage that referenced this issue Aug 10, 2018

ZevEisenberg added a commit to Raizlabs/Anchorage that referenced this issue Aug 10, 2018

norio-nomura added a commit to jpsim/Yams that referenced this issue Sep 3, 2018

gobetti added a commit to gobetti/RxCocoaNetworking that referenced this issue Sep 22, 2018

gobetti added a commit to gobetti/RxCocoaNetworking that referenced this issue Sep 22, 2018

gobetti added a commit to gobetti/RxCocoaNetworking that referenced this issue Sep 22, 2018

gobetti added a commit to gobetti/RxCocoaNetworking that referenced this issue Sep 22, 2018

ZevEisenberg added a commit to Raizlabs/Anchorage that referenced this issue Sep 22, 2018

@Jon889

This comment has been minimized.

Jon889 commented Oct 30, 2018

From the 7708 issue: the workaround is to do:

export EXPANDED_CODE_SIGN_IDENTITY=""
export EXPANDED_CODE_SIGN_IDENTITY_NAME=""
export EXPANDED_PROVISIONING_PROFILE=""

before the command to build is run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment