Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Target definition inheritance issues #955

Closed
fabiopelosin opened this Issue · 6 comments

3 participants

@fabiopelosin
Owner

Given the following Podfile:

# Links with a OS X 10.8 target 
pod 'APod'

target 'target_mobile' do
  # Links with a iOS 6.0 target 
  pod 'APod'
end

The target_mobile will be computed as OS X 10.8. This is because:

  1. The platform of the first target is auto detected
  2. The platform is stored in the target definition so the resolver can use it.
  3. The child target inherits the platform from the parent
  4. As the child target has a platform it is not auto-detected.

I'm not sure about the best way to solve this.

@alloy
Owner

So the target_mobile target would still work properly if it would contain the platform :ios directive?

@fabiopelosin
Owner

@alloy Yes, if you specify the manually platform it works properly.

@alloy
Owner

Without reading too much of the current implementation, I’d say the ideal solution would be to flag a platform as being ‘explicit’ or ‘implicit’. If it’s implicit, child targets need to be automatically resolved as well.

I do worry that it might become too complex and we should have just not gone down the ‘automatic’ road. Do you think this would make it even more complex?

@fabiopelosin
Owner

The only automatic road doesn't allow non-integrating installations. Your solution would work, however I agree that we need to rethink a bit how target definition work (see #840), to keep things simple.

@fabiopelosin

Moving to #840

@CocoaPodsBot
Collaborator

@confidenceJuice closed with reason ">Moving to #840"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.