Set STRIP_INSTALLED_PRODUCT=NO in the Pods Xcode project #1217

Merged
merged 3 commits into from Jul 23, 2013

4 participants

@amolloy

This pull request will set STRIP_INSTALLED_PRODUCT=NO in the generated Pods Xcode project.

Justification
When performing an Archive build (via Product->Archive, but not Product->Build For->Archiving), Xcode will ignore target-level settings for STRIP_INSTALLED_PRODUCT and use the project's setting instead. Since the default setting for STRIP_INSTALLED_PRODUCT at the project level is YES, this means Xcode will strip debug symbols from CocoaPods-generated libraries when Archiving. The dSYM generated by the Archive build will therefore be missing symbols from any CocoaPods used in the project. This, in turn, makes it impossible to fully symbolicate crash logs from apps built with CocoaPods via the Archive build. Disabling STRIP_INSTALLED_PRODUCT at the project level skips this strip process, allowing the resulting dSYM to contain symbols from CocoaPods. This does not affect stripping debug symbols from the final application binary.

Andy Molloy added some commits Jul 22, 2013
Andy Molloy Add the STRIP_INSTALLED_PRODUCT buld setting to the Pods project, set…
…ting it to 'NO'. This will prevent Xcode from stripping debug symbols from the Pods libraries while performing an archive build, allowing the main project targets to include pods symbols in generated dSYMs for Archive builds.
61ff4fc
Andy Molloy Update spec to pass with the addition of the STRIP_INSTALLED_PRODUCT …
…to the generated Pods Xcode projects.
61a7831
@coveralls

Coverage Status

Coverage remained the same when pulling 61a7831 on amolloy:DontStripInstalledProduct into 739f4f4 on CocoaPods:master.

@fabiopelosin
CocoaPods member

Sounds good and reasonable to me, if @alloy agrees could you add a note to the Changelog?

@alloy
CocoaPods member

Damn, I fully agree. 👍

@coveralls

Coverage Status

Coverage remained the same when pulling a1428d0 on amolloy:DontStripInstalledProduct into 739f4f4 on CocoaPods:master.

@alloy alloy merged commit d4041e5 into CocoaPods:master Jul 23, 2013

1 check passed

Details default The Travis CI build passed
@alloy
CocoaPods member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment