Don't assume that every repository has a remote that we can pull #1379

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@kylef

My Ruby is a little rusty, I haven't touched ruby in something like 3 years.

@coveralls

Coverage Status

Coverage remained the same when pulling a0cb970 on kylef:issue1378 into ff7b81f on CocoaPods:master.

@coveralls

Coverage Status

Coverage remained the same when pulling 3483cb0 on kylef:issue1378 into ff7b81f on CocoaPods:master.

@coveralls

Coverage Status

Coverage remained the same when pulling 3483cb0 on kylef:issue1378 into ff7b81f on CocoaPods:master.

@alloy
CocoaPods member

Awesome, thanks!

Three things:

  • we don’t use the and and not keywords (I haven’t used it for ages, as the precedence is different from && and !)
  • please add a test so we don’t break this in the future
  • add an entry to the CHANGELOG
@kylef
@fabiopelosin
CocoaPods member

👍

@coveralls

Coverage Status

Coverage remained the same when pulling f8e8219 on kylef:issue1378 into 50e19ae on CocoaPods:master.

@kylef

I have made all changes except the tests. I did this pretty backwards without TDD due to not being very familiar with bundle/ruby (I haven't touched Ruby in many years). Thus, I edited my local installed version of CocoaPods and then made the same changes to the repository. I didn't want to figure out how to actually install this project from the repo at the time.

I've tried to use bundle to install all dependencies for development, however it's taking some time on my very primitive internet connection I have while in Spain. I will try again when I have more bandwidth :).

@AliSoftware AliSoftware commented on an outdated diff Sep 21, 2013
lib/cocoapods/sources_manager.rb
@@ -171,6 +171,17 @@ def git_repo?(dir)
$?.exitstatus.zero?
end
+ # Returns whether a source GIT repository has a remote
+ #
+ # @param [Pathname] dir
+ # The directory where the soruce is stored.
@AliSoftware
AliSoftware Sep 21, 2013

tiny typo there ^^

@orta
CocoaPods member

Is this worth taking a second to get back into a mergable state? ( also thanks @AliSoftware )

@kylef

Yes, I will resolve all this when I get a chance (over the weekend).

@coveralls

Coverage Status

Coverage remained the same when pulling 7c015f9 on kylef:issue1378 into 23abea7 on CocoaPods:master.

@orta orta commented on the diff Sep 29, 2013
lib/cocoapods/sources_manager.rb
@@ -171,6 +171,17 @@ def git_repo?(dir)
$?.exitstatus.zero?
end
+ # Returns whether a source GIT repository has a remote
+ #
+ # @param [Pathname] dir
+ # The directory where the source is stored.
+ #
+ # @return [Bool] Wether the given GIT repository has a remote endpoint.
@kylef
kylef Sep 29, 2013

I copied and pasted that from the comment a method up ;)

@fabiopelosin
fabiopelosin Oct 1, 2013

That's just me! 😄 Don't know why but I love to spell whether that way 🍻 The whole code base is littered with that misspell. I will need to fix it one day or the other.

@fabiopelosin
CocoaPods member

What is the state of this?

@coveralls

Coverage Status

Coverage remained the same when pulling 567b74c on kylef:issue1378 into 669f926 on CocoaPods:master.

@fabiopelosin
CocoaPods member

Can I merge this?

@fabiopelosin
CocoaPods member

Bump!

@orta
CocoaPods member

Think this was decided in chat to be not worth it.

@orta orta closed this Dec 4, 2013
@fabiopelosin
CocoaPods member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment