Set Pods' deployment target to the user project setting. #1491

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

I hope that CP can check the platform and version through Podfile and set Pod target's deployment target to the user project setting!

I think my code is simple, I hope somebody can receive my idea and update CP.

see #1241

Coverage Status

Coverage remained the same when pulling 1d7f686 on Whirlwind:master into 29697f4 on CocoaPods:master.

Contributor

rivera-ernesto commented Oct 18, 2013

I think this is related to #1376.

Owner

fabiopelosin commented Nov 11, 2013

This should use a logic similar to this one: https://github.com/Whirlwind/CocoaPods/blob/1d7f6860f18dba2a3bcc0ac4d13f093805678053/lib/cocoapods/installer/analyzer.rb#L436. Looking at the first build.

Also this patch is non functional because there might be more than one user projects. The intent makes sense though.

Closing for now.

Owner

fabiopelosin commented Nov 11, 2013

Noted in #1576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment