Avoid compiling xcassets in some cases #1521

Merged
merged 2 commits into from Oct 29, 2013

Conversation

Projects
None yet
3 participants
Contributor

nmccann commented Oct 28, 2013

Added a condition to avoid compiling xcassets when WRAPPER_EXTENSION
is undefined, as it would be in the case of static libraries. This prevents
trying to copy the compiled files to a directory that does not exist.

See #1427 (comment)
for additional details. Essentially, xcassets were always being compiled regardless of if
they were needed or not.

Quick question: I notice that some scripts use [[ as opposed to [, should we use one over the other?

@nmccann nmccann Avoid compiling xcassets in some cases
Added a condition to avoid compiling xcassets when WRAPPER_EXTENSION
is undefined, as it would be in the case of static libraries. This prevents
trying to copy the compiled files to a directory that does not exist.
4565f01

Coverage Status

Coverage remained the same when pulling 4565f01 on nmccann:feature/fix_resources_script into 92aa8a2 on CocoaPods:master.

Owner

alloy commented Oct 28, 2013

The specs fail because the integration spec fixtures need to be updated, so this is actually passing. Thanks!

Owner

alloy commented Oct 28, 2013

Oh btw, can you add an entry to the CHANGELOG?

Contributor

nmccann commented Oct 28, 2013

Sure will do, by the way, what is your preference for square brackets in an if statement, do you prefer [[ or [?

Coverage Status

Coverage remained the same when pulling 0ba86b3 on nmccann:feature/fix_resources_script into 92aa8a2 on CocoaPods:master.

Owner

alloy commented Oct 29, 2013

what is your preference for square brackets in an if statement, do you prefer [[ or [?

I have no personal preference, mainly because I have no real knowledge on the subject. I assume one is chosen over the other for a reason?

Owner

alloy commented Oct 29, 2013

Thanks for the work btw!

@alloy alloy added a commit that referenced this pull request Oct 29, 2013

@alloy alloy Merge pull request #1521 from nmccann/feature/fix_resources_script
Avoid compiling xcassets in some cases
8cbdcdb

@alloy alloy merged commit 8cbdcdb into CocoaPods:master Oct 29, 2013

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment