Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Relative pod root #154

Closed
wants to merge 16 commits into from

2 participants

@subdigital

Starting to make my relative path changes here so it stays in sync with master.

The direction I'm heading is this:

  • Add a xcodeproj "subdir/myapp.xcodeproj" setting (optional) in the Podfile
  • It will use this if a path is not provided via the installer command
  • The PODS_ROOT var will be calculated relative to the Xcode project path provided (either in the Podfile or in the command line arg.
subdigital added some commits
@subdigital subdigital Run rake bootstrap to set up your working copy.
Currently initializes & updates all git submodules
70fc65e
@subdigital subdigital Added relative path example project 772168f
@subdigital subdigital rake bootstrap now bundle installs
Assists in getting a fresh working copy up and running
with a single command.
ecabe89
@subdigital subdigital Podfile specifies project path
This will allow more flexible paths where the won't have
to type the path to the install command each time.
e4fbc05
@subdigital subdigital Validate setting the pods root variable ae0d33e
@subdigital subdigital Don't validate the git repo settings, as the installer cleans it out.
(Not sure which is correct behavior, but I assumed this test was wrong)
74c8412
@subdigital

Also, the integration_spec was failing because it was checking for a git repository in a cloned pod, however the installer cleans out the .git folder. I'm assuming that is correct behavior and the test is wrong, so I've removed this assertion in 74c8412.

@alloy
Owner

Ah that was what was causing this failure, makes sense.

@alloy
Owner

It will use this if a path is not provided via the installer command

That behavior should be fully removed imo. I find it makes it unnecessarily hard to explain when you need to specify it and when not and even if we explain it people miss when to use it.

Therefor I prefer that if an xcodeproj is not explicitly specified in the Podfile, that we just see if there’s one xcodeproj in the same directory as the Podfile and, if so, use that. If not one xcodeproj is found and none is specified in the Podfile, then it should complain and exit.

@alloy
Owner

Adding a reference to #138 where we already discussed this. Can that ticket be closed btw?

@subdigital
@alloy
Owner

Can you please add the name of the author and a link to https://gist.github.com/1972906?

Come to think of it, is there some rule somewhere which says that public gists are available under an open-source license?

@alloy
Owner

Cool, thanks.

@alloy
Owner

@subdigital What’s the status on this? I’d like to start merging these branches :)

@subdigital
@alloy
Owner

Cool, thanks :)

@alloy alloy was assigned
@alloy
Owner

Closed by 23626ca.

@alloy alloy closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 8, 2012
  1. @subdigital

    Run rake bootstrap to set up your working copy.

    subdigital authored
    Currently initializes & updates all git submodules
  2. @subdigital
  3. @subdigital

    rake bootstrap now bundle installs

    subdigital authored
    Assists in getting a fresh working copy up and running
    with a single command.
  4. @subdigital

    Podfile specifies project path

    subdigital authored
    This will allow more flexible paths where the won't have
    to type the path to the install command each time.
  5. @subdigital
  6. @subdigital

    Don't validate the git repo settings, as the installer cleans it out.

    subdigital authored
    (Not sure which is correct behavior, but I assumed this test was wrong)
Commits on Mar 9, 2012
  1. @subdigital
  2. @subdigital
  3. @subdigital
  4. @subdigital
  5. @subdigital
  6. @subdigital
  7. @subdigital

    the test setup moves the config.project_pods_root in a non-standard way

    subdigital authored
    I don't think this is the place to be asserting the path behavior anyway,
    so I'm now just verifying that the build var gets set.
  8. @subdigital
  9. @subdigital
  10. @subdigital
Something went wrong with that request. Please try again.