[Bazaar] Add Bazaar support #1579

Closed
wants to merge 3 commits into from

5 participants

@fmccann

This is the same changes from my original pull request (#1531) with the noisy travis-ci commits squashed into a single commit. I suggest we abandon the bar branch and pull from this one.

@coveralls

Coverage Status

Coverage increased (+0.13%) when pulling 9576984 on fmccann:bzr2 into aa25ac0 on CocoaPods:master.

@alloy alloy commented on the diff Nov 12, 2013
.travis.yml
- source ~/.rvm/scripts/rvm && rvm use $RVM_RUBY_VERSION
+ - curl http://curl.haxx.se/ca/cacert.pem -o /usr/local/share/cacert.pem && export SSL_CERT_FILE=/usr/local/share/cacert.pem && export PYTHONPATH=/usr/local/lib/python2.7/site-packages && brew update && brew install bzr
@alloy
CocoaPods member
alloy added a note Nov 12, 2013

If we’re going to fetch the CA certs and export them for every test run anyways, then it’s best to remove it from the second RUBY_VERSION_SPECIFIC var above so that it’s only done once per test run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@alloy
CocoaPods member

It’s almost ready to be merged, but could you please add a CHANGELOG entry crediting yourself first?

@fabiopelosin
CocoaPods member

Ah true, I forgot about the changelog!

@fabiopelosin
CocoaPods member

Eloy, any suggestion about the failures of this patch only on one build?

NoMethodError: undefined method `write_plist' for Xcodeproj:Module
@alloy
CocoaPods member

@irrationalfab I don’t see any output that it’s using the precompiled extension, but it’s the only thing I can imagine.

As you can see from the paths, it has installed the gem with Ruby 1.8.x:

/Users/travis/build/CocoaPods/CocoaPods/travis_bundle_dir/ruby/1.8/bundler/gems/Xcodeproj-ceae7a7be45e/lib/xcodeproj/project.rb:303:in `save': In general - adds the Pods project to the workspace

But RVM is actually using 1.9.3. This is not what we wanted at all when we say ‘use system’. In that case we want the system ruby, which is 1.8.7.

I don’t have time atm to look into this, if you do, please investigate this.

/cc @henrikhodne

@fabiopelosin
CocoaPods member

@alloy As you say it appears that system Ruby is resolving to 1.9.3 which should never be the case. At the moment, the only explanation that I have is misconfiguration in Travis.

@fabiopelosin
CocoaPods member

Ok, the tests where a temporary issue. @fmccann Can you add a note to the changelog?

@fmccann
@alloy
CocoaPods member

@fmccann To the current ‘Master’ section.

@orta
CocoaPods member

This looks good, but looks like it needs a rebase 👍

@fmccann
@fmccann fmccann closed this Nov 28, 2013
@fmccann fmccann deleted the unknown repository branch Nov 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment