Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add regexp search capabilities to full text search and lower memory usage. #1643

Merged
merged 4 commits into from Dec 4, 2013

Conversation

Projects
None yet
3 participants
Owner

floere commented Dec 3, 2013

This is a small rewrite to the full text search

pod search <query>

which makes it possible to use regular expressions.

It also slightly lowers memory usage, because it avoids using temporary strings. Instead, it uses an Array of existing strings.

I've added only a single spec which shows off the capability. Please let me know if you need more examples.

grep ftw! :)

Owner

floere replied Dec 3, 2013

I know right! ;)

Owner

fabiopelosin replied Dec 3, 2013

💥

Owner

fabiopelosin replied Dec 3, 2013

Btw, this deserves a mention in the changelog. If I'm correct regular expressions should work directly from the command line!

Owner

floere replied Dec 3, 2013

@irrationalfab Ok – @alloy also asked me to add a mention. Cheers!

Owner

alloy commented Dec 3, 2013

Excellent!

Can you add a CHANGELOG entry crediting yourself?

Owner

fabiopelosin commented Dec 3, 2013

👍

Owner

floere commented Dec 3, 2013

I added a CHANGELOG entry :)

Owner

alloy commented Dec 4, 2013

❤️

@alloy alloy added a commit that referenced this pull request Dec 4, 2013

@alloy alloy Merge pull request #1643 from CocoaPods/regexp-search
Add regexp search capabilities to full text search and lower memory usage.
1404110

@alloy alloy merged commit 1404110 into master Dec 4, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details

@fabiopelosin fabiopelosin deleted the regexp-search branch Dec 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment