[Push] Silently test the trunk.cocoapods service #1646

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@fabiopelosin
Owner

fabiopelosin commented Dec 4, 2013

No description provided.

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Dec 4, 2013

Owner

s/not/now/ ;) I would also restructure it to be “will now silently test”

Owner

alloy commented on CHANGELOG.md in 7536192 Dec 4, 2013

s/not/now/ ;) I would also restructure it to be “will now silently test”

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Dec 4, 2013

Owner

s/affects/affect/

I’m also not sure what “of the operations” adds.

Owner

alloy commented on CHANGELOG.md in 7536192 Dec 4, 2013

s/affects/affect/

I’m also not sure what “of the operations” adds.

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Dec 4, 2013

Owner

I’m actually not really sure if this catches all possible exceptions. Maybe make it rescue Object, as all exceptions inherit from Object at some point?

I’m actually not really sure if this catches all possible exceptions. Maybe make it rescue Object, as all exceptions inherit from Object at some point?

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Dec 4, 2013

Owner

http://www.ruby-doc.org/core-2.0.0/Exception.html

StandardError -- default for rescue
Owner

fabiopelosin replied Dec 4, 2013

http://www.ruby-doc.org/core-2.0.0/Exception.html

StandardError -- default for rescue

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Dec 4, 2013

Owner

I think that we are fine with StandardError

Owner

fabiopelosin replied Dec 4, 2013

I think that we are fine with StandardError

+ # @return [void] Silently test the CocoaPods trunk service.
+ #
+ def test_trunk
+ return unless @repo == "master"

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Dec 4, 2013

Owner

Can we use the origin URL of the repo here instead? Theoretically a user could have their ‘master’ repo point elsewhere.

@alloy

alloy Dec 4, 2013

Owner

Can we use the origin URL of the repo here instead? Theoretically a user could have their ‘master’ repo point elsewhere.

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Dec 4, 2013

Owner

This command only reason in terms of repo names. However the unspoken rule is master is reserved for us.

@fabiopelosin

fabiopelosin Dec 4, 2013

Owner

This command only reason in terms of repo names. However the unspoken rule is master is reserved for us.

This comment has been minimized.

Show comment Hide comment
@orta

orta Dec 5, 2013

Owner

However the unspoken rule is master is reserved for us.

Is this taken into account on pod repo add ?

@orta

orta Dec 5, 2013

Owner

However the unspoken rule is master is reserved for us.

Is this taken into account on pod repo add ?

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Dec 5, 2013

Owner

@orta no, I don't think so.

@fabiopelosin

fabiopelosin Dec 5, 2013

Owner

@orta no, I don't think so.

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Dec 5, 2013

Owner

Do it.

Owner

alloy commented Dec 5, 2013

Do it.

@fabiopelosin

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Dec 5, 2013

Owner

Merged via d87aa83.

Owner

fabiopelosin commented Dec 5, 2013

Merged via d87aa83.

@fabiopelosin

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Dec 5, 2013

Owner

I have opted to catch Exception instances at the end.

Owner

fabiopelosin commented Dec 5, 2013

I have opted to catch Exception instances at the end.

@fabiopelosin fabiopelosin deleted the trunk-test branch Aug 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment