Properly check to see if changes were made on push #1739

Merged
merged 3 commits into from Mar 28, 2014

Projects

None yet

2 participants

@gfontenot
Contributor

The original implementation made poor assumptions about the name of the pod,
and used it as a regex pattern. This led to problems when trying to push specs
that contained special characters in their names (such as + for category
specs). Instead of using a regex, we should just do a substring match to see
if the output contains the spec name.

Fixes #1737

@gfontenot gfontenot Properly check to see if changes were made on push
The original implementation made poor assumptions about the name of the
pod, and used it as a regex pattern. This led to problems when trying to
push specs that contained special characters in their names (such as `+`
for category specs). Instead of using a regex, we should just do a
substring match to see if the output contains the spec name.
60fc0c5
@fabiopelosin
Member

Good call, can you use braces to conform to the CocoaPods code style. Moreover can you add an entry to the changelog?

@gfontenot
Contributor

Done and done.

@fabiopelosin fabiopelosin merged commit e1ff91d into master Mar 28, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@fabiopelosin fabiopelosin deleted the gf-fix-pod-push branch Aug 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment