Uniformize spec template quotes #1819

Merged
merged 2 commits into from Feb 12, 2014

Conversation

Projects
None yet
3 participants
@vtourraine
Contributor

vtourraine commented Feb 12, 2014

Take that as a personal OCD, but I’d rather see uniform quotation marks in the spec template. Or am I missing something?

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 12, 2014

Owner

I agree that consistency is nicer to look at. However, Ruby does not do interpolation in single quoted strings, so these should all be double quotes instead. If you can update that I will merge it.

Owner

alloy commented Feb 12, 2014

I agree that consistency is nicer to look at. However, Ruby does not do interpolation in single quoted strings, so these should all be double quotes instead. If you can update that I will merge it.

@vtourraine

This comment has been minimized.

Show comment Hide comment
@vtourraine

vtourraine Feb 12, 2014

Contributor

Double quotes it is. Thanks for the feedback.

Contributor

vtourraine commented Feb 12, 2014

Double quotes it is. Thanks for the feedback.

@alloy

This comment has been minimized.

Show comment Hide comment
@alloy

alloy Feb 12, 2014

Owner

Perfect, thanks!

Owner

alloy commented Feb 12, 2014

Perfect, thanks!

alloy added a commit that referenced this pull request Feb 12, 2014

Merge pull request #1819 from vtourraine/master
Uniformize spec template quotes

@alloy alloy merged commit 234bf1e into CocoaPods:master Feb 12, 2014

1 check passed

default The Travis CI build passed
Details
@fabiopelosin

This comment has been minimized.

Show comment Hide comment
@fabiopelosin

fabiopelosin Feb 12, 2014

Owner

👍

Owner

fabiopelosin commented Feb 12, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment